Re: question on freeze and aio

From: Randy Dunlap <rdunlap@xenotime.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-pm@lists.osdl.org
Subject: Re: question on freeze and aio
Date: Wed, 14 Feb 2007 09:25:10 -0800	[thread overview]
Message-ID: <20070214092510.5468db34.rdunlap@xenotime.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0702131557400.2741-100000@iolanthe.rowland.org>

On Tue, 13 Feb 2007 16:01:30 -0500 (EST) Alan Stern wrote:

> On Tue, 13 Feb 2007, Pavel Machek wrote:
> 
> > > No, workqueues are not frozen unless they are explicitly declared as
> > > freezeable.  Which currently is only done by XFS, AFAIKS.
> > 
> > Ok, then we have a bug in swsusp. Can someone locate _which_ workqueue
> > is used for aio... and make it freezeable?
> 
> Here is an untested patch.  Does anybody have a way to test it?
> 
> (BTW, should it be spelled "freezeable" or "freezable"?)

www.dict.org says freezable.

> Index: usb-2.6/fs/aio.c
> ===================================================================
> --- usb-2.6.orig/fs/aio.c
> +++ usb-2.6/fs/aio.c
> @@ -73,7 +73,7 @@ static int __init aio_setup(void)
>  	kioctx_cachep = kmem_cache_create("kioctx", sizeof(struct kioctx),
>  				0, SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL, NULL);
>  
> -	aio_wq = create_workqueue("aio");
> +	aio_wq = create_freezeable_workqueue("aio");
>  
>  	pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page));

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***