All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ACPI: bay: use IS_ERR for return of register_platform_device_simple
@ 2007-02-14 12:55 Henrique de Moraes Holschuh
  2007-02-14 21:14 ` Len Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Henrique de Moraes Holschuh @ 2007-02-14 12:55 UTC (permalink / raw)
  To: linux-acpi, lenb

register_platform_device_simple returns ERR_PTR(foo), so test it with
IS_ERR(foo).

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

---

I wonder how many of these are in the kernel?  An annotation for this would be
a good idea.  It doesn't help that people, as usual, do not see fit to document
how the heck they return errors, so you have to track down the source of every
function you are not intimately familiar with before using it.
---
 drivers/acpi/bay.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
index dcf5f42..fb3f31b 100644
--- a/drivers/acpi/bay.c
+++ b/drivers/acpi/bay.c
@@ -281,7 +281,7 @@ static int bay_add(acpi_handle handle, int id)
 
 	/* initialize platform device stuff */
 	pdev = platform_device_register_simple(ACPI_BAY_CLASS, id, NULL, 0);
-	if (pdev == NULL) {
+	if (IS_ERR(pdev)) {
 		printk(KERN_ERR PREFIX "Error registering bay device\n");
 		goto bay_add_err;
 	}
-- 
1.4.4.4

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ACPI: bay: use IS_ERR for return of register_platform_device_simple
  2007-02-14 12:55 [PATCH] ACPI: bay: use IS_ERR for return of register_platform_device_simple Henrique de Moraes Holschuh
@ 2007-02-14 21:14 ` Len Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2007-02-14 21:14 UTC (permalink / raw)
  To: Henrique de Moraes Holschuh; +Cc: linux-acpi, Kristen Carlson Accardi

Applied,

thanks,
-Len

On Wednesday 14 February 2007 07:55, Henrique de Moraes Holschuh wrote:
> register_platform_device_simple returns ERR_PTR(foo), so test it with
> IS_ERR(foo).
> 
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> 
> ---
> 
> I wonder how many of these are in the kernel?  An annotation for this would be
> a good idea.  It doesn't help that people, as usual, do not see fit to document
> how the heck they return errors, so you have to track down the source of every
> function you are not intimately familiar with before using it.
> ---
>  drivers/acpi/bay.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
> index dcf5f42..fb3f31b 100644
> --- a/drivers/acpi/bay.c
> +++ b/drivers/acpi/bay.c
> @@ -281,7 +281,7 @@ static int bay_add(acpi_handle handle, int id)
>  
>  	/* initialize platform device stuff */
>  	pdev = platform_device_register_simple(ACPI_BAY_CLASS, id, NULL, 0);
> -	if (pdev == NULL) {
> +	if (IS_ERR(pdev)) {
>  		printk(KERN_ERR PREFIX "Error registering bay device\n");
>  		goto bay_add_err;
>  	}
> -- 
> 1.4.4.4
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-14 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-14 12:55 [PATCH] ACPI: bay: use IS_ERR for return of register_platform_device_simple Henrique de Moraes Holschuh
2007-02-14 21:14 ` Len Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.