From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Li Subject: Re: [PATCH] Re: Sparse just seg faulted on me! Date: Wed, 14 Feb 2007 12:18:55 -0800 Message-ID: <20070214201855.GC18753@chrisli.org> References: <9C17AC42-0C51-44D9-B126-1FB781DE0ECA@cam.ac.uk> <20070214172905.GA17959@chrisli.org> <20070214195447.GA18753@chrisli.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from sccrmhc13.comcast.net ([63.240.77.83]:58651 "EHLO sccrmhc13.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbXBNUsl (ORCPT ); Wed, 14 Feb 2007 15:48:41 -0500 Content-Disposition: inline In-Reply-To: <20070214195447.GA18753@chrisli.org> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Linus Torvalds Cc: Anton Altaparmakov , Sparse , Josh Triplett On Wed, Feb 14, 2007 at 11:54:47AM -0800, Christopher Li wrote: > On Wed, Feb 14, 2007 at 10:24:09AM -0800, Linus Torvalds wrote: > > Actually, it's often better to just explicitly make "ctype" be > > "&bad_ctype" instead. > > > > It's nice if a NULL type means "type has not been evaluated yet", and then > > using "&bad_ctype" to mean "type evaluated to crap". > > Good idea. Some of the code already doing that. I am making it as a separate > patch because touch a lot of code. This is very messy. The current evaluate_* functions are assuming NULL means for "some error happen in this expression, I can't get the ctype". It is all over the place. Chris