From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: dmueller@osuse.de, James.Bottomley@SteelEye.com, eric.moore@lsi.com
Subject: + fix--confusion-in-fusion-driver.patch added to -mm tree
Date: Wed, 14 Feb 2007 13:08:07 -0800 [thread overview]
Message-ID: <200702142108.l1EL87gC009119@shell0.pdx.osdl.net> (raw)
The patch titled
Fix |/|| confusion in fusion driver
has been added to the -mm tree. Its filename is
fix--confusion-in-fusion-driver.patch
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: Fix |/|| confusion in fusion driver
From: Dirk Mueller <dmueller@osuse.de>
This patch corrects a |/|| confusion in mptscsih_copy_sense_data. Using ||
means that the data that ends up being written is (almost always) 1,
instead of being bit-wise or'ed.
Cc: Eric Moore <eric.moore@lsi.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/message/fusion/mptscsih.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff -puN drivers/message/fusion/mptscsih.c~fix--confusion-in-fusion-driver drivers/message/fusion/mptscsih.c
--- a/drivers/message/fusion/mptscsih.c~fix--confusion-in-fusion-driver
+++ a/drivers/message/fusion/mptscsih.c
@@ -2474,9 +2474,9 @@ mptscsih_copy_sense_data(struct scsi_cmn
ioc->events[idx].event = MPI_EVENT_SCSI_DEVICE_STATUS_CHANGE;
ioc->events[idx].eventContext = ioc->eventContext;
- ioc->events[idx].data[0] = (pReq->LUN[1] << 24) ||
- (MPI_EVENT_SCSI_DEV_STAT_RC_SMART_DATA << 16) ||
- (sc->device->channel << 8) || sc->device->id;
+ ioc->events[idx].data[0] = (pReq->LUN[1] << 24) |
+ (MPI_EVENT_SCSI_DEV_STAT_RC_SMART_DATA << 16) |
+ (sc->device->channel << 8) | sc->device->id;
ioc->events[idx].data[1] = (sense_data[13] << 8) || sense_data[12];
_
Patches currently in -mm which might be from dmueller@osuse.de are
fix--confusion-in-fusion-driver.patch
reply other threads:[~2007-02-14 21:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702142108.l1EL87gC009119@shell0.pdx.osdl.net \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@SteelEye.com \
--cc=dmueller@osuse.de \
--cc=eric.moore@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.