From: David Brownell <david-b@pacbell.net>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linuxppc-dev@ozlabs.org, greg@kroah.com,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH] ps3: don't call ps3_system_bus_driver_register on other platforms
Date: Fri, 16 Feb 2007 17:33:55 -0800 [thread overview]
Message-ID: <200702161733.56506.david-b@pacbell.net> (raw)
In-Reply-To: <45D36285.2010102@am.sony.com>
On Wednesday 14 February 2007 11:27 am, Geoff Levand wrote:
> Ishizaki Kou wrote:
> > ps3_system_bus_driver_register is PS3 platform specific function.
> > On other platforms, it triggers WARN_ON in kref_get.
>
> > +++ linux-powerpc-git/drivers/usb/host/ehci-hcd.c
> > +++ linux-powerpc-git/drivers/usb/host/ohci-hcd.c
>
> I would think we only need to modify ps3_system_bus_driver_register()
> and ps3_system_bus_driver_unregister() to do the proper thing, not the
> usb host drivers that make those calls. I'll look into that solution.
Right, that seems like the real bug. When that's fixed, this patch
can/should be backed out...
- Dave
next prev parent reply other threads:[~2007-02-17 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 7:04 [PATCH] ps3: don't call ps3_system_bus_driver_register on other platforms Ishizaki Kou
2007-02-14 19:27 ` Geoff Levand
2007-02-17 1:33 ` David Brownell [this message]
2007-02-14 21:22 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702161733.56506.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=geoffrey.levand@am.sony.com \
--cc=greg@kroah.com \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.