All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alex Dubov <oakad@yahoo.com>
Cc: Pavel Machek <pavel@ucw.cz>, Pierre Ossman <drzeus-mmc@drzeus.cx>,
	Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [mmc] incorrect behavior on resume
Date: Sun, 18 Feb 2007 06:53:18 +0000	[thread overview]
Message-ID: <20070218065318.GA14251@flint.arm.linux.org.uk> (raw)
In-Reply-To: <40069.12630.qm@web36708.mail.mud.yahoo.com>

On Sat, Feb 17, 2007 at 05:46:35PM -0800, Alex Dubov wrote:
> The problem here is that mmc_block's device is a child of real device
> (tifm_dev here), so it gets resumed right after it.

The host driver is supposed to call mmc_resume_host from it's resume
callback.  This should be called before the child's resume callback.

> However, it correct functioning depends on mmc_core, which must be
> manually resumed (mmc_resume_host). Therefore, I think this is
> purely mmc's problem.

I don't see that - as I say above, the correct sequence is:

 - host device resume
     - calls mmc_resume_host()
 - child's device resume (mmc_blk_resume)
     - mmc_queue_resume()

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2007-02-18  6:53 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 22:20 [2.6.20] tifm_7xx1/mmc not working Andreas Steinmetz
2007-02-08  5:59 ` Pierre Ossman
2007-02-08 23:35   ` Alex Dubov
2007-02-09 12:27     ` Andreas Steinmetz
2007-02-09 15:14   ` Recent and not-so problems with tifm_sd driver Alex Dubov
2007-02-09 19:10     ` Pierre Ossman
2007-02-10  9:12       ` Recent and not-so problems with tifm_sd driver - one more Alex Dubov
2007-02-10 13:01         ` Pierre Ossman
2007-02-11  6:03           ` Brad Campbell
2007-02-11 14:52             ` Fabio Comolli
2007-02-11 15:40             ` Pierre Ossman
2007-02-11 15:56               ` Brad Campbell
2007-02-11 18:04                 ` Pierre Ossman
2007-02-11 19:32                   ` Brad Campbell
2007-02-12  9:14                     ` Pierre Ossman
2007-02-12 10:50                       ` Brad Campbell
2007-02-12 13:21                     ` Andreas Steinmetz
2007-02-17 15:16                   ` [mmc] incorrect behavior on resume Alex Dubov
2007-02-17 23:35                     ` Pierre Ossman
2007-02-18  0:29                       ` Pavel Machek
2007-02-18  1:46                         ` Alex Dubov
2007-02-18  6:53                           ` Russell King [this message]
2007-02-18 12:18                             ` Alex Dubov
2007-02-11  4:47       ` Recent and not-so problems with tifm_sd driver Alex Dubov
2007-02-11 18:15         ` Pierre Ossman
2007-02-12 11:53           ` Alex Dubov
2007-02-12 13:49             ` Pierre Ossman
2007-02-13  0:44               ` Alex Dubov
2007-02-13 14:40               ` Alex Dubov
2007-02-17 23:14                 ` Pierre Ossman
2007-02-17 23:51             ` Pierre Ossman
2007-02-18  4:59               ` Alex Dubov
2007-02-18  8:13                 ` Pierre Ossman
2007-02-18 14:19                   ` Alex Dubov
2007-02-18 15:10                     ` Pierre Ossman
2007-02-18 23:48                       ` Alex Dubov
2007-02-19  7:06                         ` Pierre Ossman
2007-02-19 12:09                           ` Alex Dubov
2007-02-19 12:34                             ` Pierre Ossman
2007-02-20  1:30                               ` Alex Dubov
2007-02-20  7:03                                 ` Pierre Ossman
2007-03-14 14:44                               ` Weird MMC errors: 1 of 2 - bad ocr value Alex Dubov
2007-04-08 19:41                                 ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070218065318.GA14251@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oakad@yahoo.com \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.