From: Jiri Benc <jbenc@suse.cz>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jouni Malinen <jkm@devicescape.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] remove IEEE80211_HW_FRAGLIST flag
Date: Mon, 19 Feb 2007 21:24:07 +0100 [thread overview]
Message-ID: <20070219212407.58e8fb62@griffin.suse.cz> (raw)
In-Reply-To: <1171642069.3575.4.camel@johannes.berg>
On Fri, 16 Feb 2007 17:07:49 +0100, Johannes Berg wrote:
> On Fri, 2007-02-16 at 08:04 -0800, Jouni Malinen wrote:
>
> > The reason for this flag was to reduce host CPU load for frame
> > aggregation (merging multiple frames (skb's) into one frame. It was used
> > to implement one part of Atheros Super A/G enhancements, but I don't see
> > those proprietary changes being generic enough to be worth adding into
> > net/d80211. However, IEEE 802.11n has similar features that may indeed
> > benefit from this flag. As such, I would not remove it.
>
> But we can never submit fragmented SKBs currently anyway, so whenever we
> do any 802.11n changes that benefit from it we can add the flag back.
I agree. Let's add the flag later when this is actually needed.
Applied, thanks for patch!
Jiri
--
Jiri Benc
SUSE Labs
prev parent reply other threads:[~2007-02-19 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 19:53 [PATCH] remove IEEE80211_HW_FRAGLIST flag Johannes Berg
2007-02-16 16:04 ` Jouni Malinen
2007-02-16 16:07 ` Johannes Berg
2007-02-19 20:24 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070219212407.58e8fb62@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=jkm@devicescape.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.