From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965102AbXBSW3P (ORCPT ); Mon, 19 Feb 2007 17:29:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965060AbXBSW3P (ORCPT ); Mon, 19 Feb 2007 17:29:15 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:47405 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965102AbXBSW3O (ORCPT ); Mon, 19 Feb 2007 17:29:14 -0500 Date: Mon, 19 Feb 2007 22:29:06 +0000 From: Christoph Hellwig To: Adam Litke Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros. Message-ID: <20070219222906.GA16385@infradead.org> Mail-Followup-To: Christoph Hellwig , Adam Litke , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20070219183123.27318.27319.stgit@localhost.localdomain> <20070219183133.27318.92920.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070219183133.27318.92920.stgit@localhost.localdomain> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 19, 2007 at 10:31:34AM -0800, Adam Litke wrote: > Signed-off-by: Adam Litke > --- > > include/linux/mm.h | 25 +++++++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 2d2c08d..a2fa66d 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -98,6 +98,7 @@ struct vm_area_struct { > > /* Function pointers to deal with this struct. */ > struct vm_operations_struct * vm_ops; > + struct pagetable_operations_struct * pagetable_ops; > > /* Information about our backing store: */ > unsigned long vm_pgoff; /* Offset (within vm_file) in PAGE_SIZE > @@ -218,6 +219,30 @@ struct vm_operations_struct { > }; > > struct mmu_gather; > + > +struct pagetable_operations_struct { > + int (*fault)(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long address, int write_access); > + int (*copy_vma)(struct mm_struct *dst, struct mm_struct *src, > + struct vm_area_struct *vma); > + int (*pin_pages)(struct mm_struct *mm, struct vm_area_struct *vma, > + struct page **pages, struct vm_area_struct **vmas, > + unsigned long *position, int *length, int i); > + void (*change_protection)(struct vm_area_struct *vma, > + unsigned long address, unsigned long end, pgprot_t newprot); > + unsigned long (*unmap_page_range)(struct vm_area_struct *vma, > + unsigned long address, unsigned long end, long *zap_work); > + void (*free_pgtable_range)(struct mmu_gather **tlb, > + unsigned long addr, unsigned long end, > + unsigned long floor, unsigned long ceiling); > +}; I don't think adding another operation vector is a good idea. But I'd rather extend the vma operations vector to deal with all nessecary buts ubstead if addubg a second one. From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 19 Feb 2007 22:29:06 +0000 From: Christoph Hellwig Subject: Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros. Message-ID: <20070219222906.GA16385@infradead.org> References: <20070219183123.27318.27319.stgit@localhost.localdomain> <20070219183133.27318.92920.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070219183133.27318.92920.stgit@localhost.localdomain> Sender: owner-linux-mm@kvack.org Return-Path: To: Adam Litke Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Mon, Feb 19, 2007 at 10:31:34AM -0800, Adam Litke wrote: > Signed-off-by: Adam Litke > --- > > include/linux/mm.h | 25 +++++++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 2d2c08d..a2fa66d 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -98,6 +98,7 @@ struct vm_area_struct { > > /* Function pointers to deal with this struct. */ > struct vm_operations_struct * vm_ops; > + struct pagetable_operations_struct * pagetable_ops; > > /* Information about our backing store: */ > unsigned long vm_pgoff; /* Offset (within vm_file) in PAGE_SIZE > @@ -218,6 +219,30 @@ struct vm_operations_struct { > }; > > struct mmu_gather; > + > +struct pagetable_operations_struct { > + int (*fault)(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long address, int write_access); > + int (*copy_vma)(struct mm_struct *dst, struct mm_struct *src, > + struct vm_area_struct *vma); > + int (*pin_pages)(struct mm_struct *mm, struct vm_area_struct *vma, > + struct page **pages, struct vm_area_struct **vmas, > + unsigned long *position, int *length, int i); > + void (*change_protection)(struct vm_area_struct *vma, > + unsigned long address, unsigned long end, pgprot_t newprot); > + unsigned long (*unmap_page_range)(struct vm_area_struct *vma, > + unsigned long address, unsigned long end, long *zap_work); > + void (*free_pgtable_range)(struct mmu_gather **tlb, > + unsigned long addr, unsigned long end, > + unsigned long floor, unsigned long ceiling); > +}; I don't think adding another operation vector is a good idea. But I'd rather extend the vma operations vector to deal with all nessecary buts ubstead if addubg a second one. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org