* [PATCH] tty_register_driver: Remove incorrect and superfluous cast
@ 2007-02-20 14:45 Geert Uytterhoeven
2007-02-20 16:39 ` Alan
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2007-02-20 14:45 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Adrian `trivial' Bunk, Linux Kernel Development
tty_register_driver: Remove incorrect and superfluous cast (expected and passed
types are both const char *)
Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
--- ps3-linux-2.6.20.orig/drivers/char/tty_io.c
+++ ps3-linux-2.6.20/drivers/char/tty_io.c
@@ -3713,15 +3713,14 @@ int tty_register_driver(struct tty_drive
if (!driver->major) {
error = alloc_chrdev_region(&dev, driver->minor_start, driver->num,
- (char*)driver->name);
+ driver->name);
if (!error) {
driver->major = MAJOR(dev);
driver->minor_start = MINOR(dev);
}
} else {
dev = MKDEV(driver->major, driver->minor_start);
- error = register_chrdev_region(dev, driver->num,
- (char*)driver->name);
+ error = register_chrdev_region(dev, driver->num, driver->name);
}
if (error < 0) {
kfree(p);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tty_register_driver: Remove incorrect and superfluous cast
2007-02-20 14:45 [PATCH] tty_register_driver: Remove incorrect and superfluous cast Geert Uytterhoeven
@ 2007-02-20 16:39 ` Alan
0 siblings, 0 replies; 2+ messages in thread
From: Alan @ 2007-02-20 16:39 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Torvalds, Andrew Morton, Adrian `trivial' Bunk,
Linux Kernel Development
On Tue, 20 Feb 2007 15:45:21 +0100 (CET)
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
> tty_register_driver: Remove incorrect and superfluous cast (expected and passed
> types are both const char *)
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-20 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-20 14:45 [PATCH] tty_register_driver: Remove incorrect and superfluous cast Geert Uytterhoeven
2007-02-20 16:39 ` Alan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.