All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Davide Libenzi <davidel@xmailserver.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-arch@vger.kernel.org, rmk@arm.linux.org.uk,
	tony.luck@intel.com
Subject: Re: [patch 18/50] add epoll compat code to kernel/compat.c
Date: Wed, 21 Feb 2007 01:38:33 +0000	[thread overview]
Message-ID: <20070221013833.GA18968@linux-mips.org> (raw)
In-Reply-To: <20070221120145.419a03ee.sfr@canb.auug.org.au>

On Wed, Feb 21, 2007 at 12:01:45PM +1100, Stephen Rothwell wrote:

> > Reminder for Andrew ...
> > We talked about having an asm/compat.h define the proper 
> > compat_epoll_event structure, and having a define in there that triggers 
> > the proper code inside kernel/compat.c. It looks like the better way to 
> > go, as Stephen suggested.
> > If that's accepted by everyone, I can go ahead and make a patch. Lemme 
> > know ...
> 
> Like below?  I did the above and moved the code to fs/compat.c (from
> kernel/compat.c).  Also MIPS already has a compat_sys_epoll_pwait, so I
> had to add an #ifndef CONFIG_MIPS.

I suggest to remove the MIPS implementation from arch/mips/kernel/linux32.c
instead.  Aside of a microoptimization it's identical to the one you've
posted.

  Ralf

  parent reply	other threads:[~2007-02-21  1:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20 21:57 [patch 18/50] add epoll compat code to kernel/compat.c akpm
2007-02-20 23:20 ` Stephen Rothwell
2007-02-20 23:33   ` Davide Libenzi
2007-02-21  1:01     ` Stephen Rothwell
2007-02-21  1:05       ` Stephen Rothwell
2007-02-21  1:12       ` Davide Libenzi
2007-02-21  3:10         ` [PATCH]add epoll compat code to fsl/compat.c Stephen Rothwell
2007-02-21 20:24           ` Davide Libenzi
2007-02-21 20:36             ` Linus Torvalds
2007-02-21 21:04               ` Davide Libenzi
2007-02-21 21:15                 ` Linus Torvalds
2007-02-22  3:07                   ` David Miller
2007-02-22  4:03                     ` Davide Libenzi
2007-02-22  4:39                     ` Stephen Rothwell
2007-02-21 22:14                 ` Ralf Baechle
2007-02-21 22:25                   ` Davide Libenzi
2007-02-21 23:23                     ` Ralf Baechle
2007-02-22  3:02               ` David Miller
2007-02-22  3:08                 ` Davide Libenzi
2007-02-21  1:38       ` Ralf Baechle [this message]
2007-02-20 23:57   ` [patch 18/50] add epoll compat code to kernel/compat.c Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070221013833.GA18968@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=akpm@linux-foundation.org \
    --cc=davidel@xmailserver.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=sfr@canb.auug.org.au \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.