All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Benc <jbenc@suse.cz>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [RFC PATCH] d80211: fix build break from netdev class_device ->  device changes
Date: Wed, 21 Feb 2007 18:45:25 +0100	[thread overview]
Message-ID: <20070221184525.4a40779b@griffin.suse.cz> (raw)
In-Reply-To: <20070221005811.GA3875@tuxdriver.com>

On Tue, 20 Feb 2007 19:58:11 -0500, John W. Linville wrote:
> In preparation for 2.6.21-rc1, I pulled Linus' latest tree into a
> branch of wireless-dev.  I hit a build problem with the sysfs stuff,
> due to the recent changes from class_device -> device for net_device.
> 
> Since I don't count sysfs as a strength, I thought it was worth
> posting this for some review before I actually pulled Linus' latest
> into wireless-dev and slapped this on top of it... :-)
> 
> Comments?

Looks correct. Don't know if it's complete, though - I tried to pull
from Linus but there are many conflicts caused by the ssb code, I'll
leave them to you :-)

Acked-by: Jiri Benc <jbenc@suse.cz>

I wonder if we can simplify it sometime in the future as we're getting
device_attribute in the callbacks now... Probably not. And it's not
worth the effort anyway.

-- 
Jiri Benc
SUSE Labs

  parent reply	other threads:[~2007-02-21 17:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21  0:58 [RFC PATCH] d80211: fix build break from netdev class_device -> device changes John W. Linville
2007-02-21 10:45 ` Johannes Berg
2007-02-21 13:32   ` John W. Linville
2007-02-23 14:59     ` [RFC] convert wiphy to struct device Johannes Berg
2007-02-23 20:19       ` Greg KH
2007-02-23 20:33         ` Johannes Berg
2007-02-21 17:45 ` Jiri Benc [this message]
2007-02-21 17:49   ` [RFC PATCH] d80211: fix build break from netdev class_device -> device changes Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070221184525.4a40779b@griffin.suse.cz \
    --to=jbenc@suse.cz \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.