From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965242AbXCAPTX (ORCPT ); Thu, 1 Mar 2007 10:19:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965175AbXCAPSw (ORCPT ); Thu, 1 Mar 2007 10:18:52 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:48051 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965202AbXCAPRf (ORCPT ); Thu, 1 Mar 2007 10:17:35 -0500 From: "Rafael J. Wysocki" To: Andrew Morton Subject: [PATCH -mm 7/7] Freezer: Take kernel_execve into consideration Date: Thu, 1 Mar 2007 16:17:38 +0100 User-Agent: KMail/1.9.5 Cc: Pavel Machek , LKML , Oleg Nesterov , Aneesh Kumar , "Paul E. McKenney" , Srivatsa Vaddagiri , Gautham R Shenoy References: <200702260800.49603.rjw@sisk.pl> <200703011605.46692.rjw@sisk.pl> In-Reply-To: <200703011605.46692.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703011617.39251.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: Rafael J. Wysocki Kernel threads can become userland processes by calling kernel_execve(). In particular, this may happen right after try_to_freeze_tasks(FREEZER_USER_SPACE) has returned, so try_to_freeze_tasks() needs to take userspace processes into consideration even if it is called with FREEZER_KERNEL_THREADS. Signed-off-by: Rafael J. Wysocki Acked-by: Pavel Machek --- kernel/power/process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.20-mm2/kernel/power/process.c =================================================================== --- linux-2.6.20-mm2.orig/kernel/power/process.c +++ linux-2.6.20-mm2/kernel/power/process.c @@ -127,7 +127,7 @@ static unsigned int try_to_freeze_tasks( cancel_freezing(p); continue; } - if (is_user_space(p) == !freeze_user_space) + if (freeze_user_space && !is_user_space(p)) continue; freeze_process(p); @@ -154,7 +154,7 @@ static unsigned int try_to_freeze_tasks( TIMEOUT / HZ, todo); read_lock(&tasklist_lock); do_each_thread(g, p) { - if (is_user_space(p) == !freeze_user_space) + if (freeze_user_space && !is_user_space(p)) continue; task_lock(p);