From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423003AbXCBKbJ (ORCPT ); Fri, 2 Mar 2007 05:31:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161328AbXCBKbI (ORCPT ); Fri, 2 Mar 2007 05:31:08 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:58045 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161184AbXCBKbG (ORCPT ); Fri, 2 Mar 2007 05:31:06 -0500 Date: Fri, 2 Mar 2007 11:22:16 +0100 From: Ingo Molnar To: Linus Torvalds Cc: Jens Axboe , Pavel Machek , Adrian Bunk , Andrew Morton , Linux Kernel Mailing List , "Michael S. Tsirkin" , Thomas Gleixner , linux-pm@lists.osdl.org, Michal Piotrowski , Daniel Walker , Len Brown , git@vger.kernel.org, Avi Kivity Subject: [patch] KVM: T60 resume fix Message-ID: <20070302102216.GA13575@elte.hu> References: <20070227103407.GA17819@elte.hu> <20070227105922.GD2250@kernel.dk> <20070227111515.GA4271@kernel.dk> <20070301093450.GA8508@elte.hu> <20070301104117.GA22788@elte.hu> <20070301145204.GA25304@elte.hu> <20070302072100.GB30634@elte.hu> <20070302080441.GA12785@elte.hu> <20070302102018.GA11549@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070302102018.GA11549@elte.hu> User-Agent: Mutt/1.4.2.2i X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.0.3 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Subject: [patch] KVM: T60 resume fix From: Ingo Molnar my T60 laptop does not resume correctly due to KVM attempting to send an IPI to a CPU that might be down (or not up yet). (Doing so also triggers the send_IPI_mask_bitmask() warning in arch/i386/kernel/smp.c, line 732.) with this fix applied my laptop does not hang during resume. [ KVM will have to disable/enable virtualization on the CPU itself that goes down / comes up, not via an IPI sent from the requesting CPU. ] Signed-off-by: Ingo Molnar --- drivers/kvm/kvm_main.c | 6 ------ 1 file changed, 6 deletions(-) Index: linux/drivers/kvm/kvm_main.c =================================================================== --- linux.orig/drivers/kvm/kvm_main.c +++ linux/drivers/kvm/kvm_main.c @@ -2083,12 +2083,6 @@ static int kvm_cpu_hotplug(struct notifi case CPU_DEAD: case CPU_UP_CANCELED: decache_vcpus_on_cpu(cpu); - smp_call_function_single(cpu, kvm_arch_ops->hardware_disable, - NULL, 0, 1); - break; - case CPU_UP_PREPARE: - smp_call_function_single(cpu, kvm_arch_ops->hardware_enable, - NULL, 0, 1); break; } return NOTIFY_OK; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: [patch] KVM: T60 resume fix Date: Fri, 2 Mar 2007 11:22:16 +0100 Message-ID: <20070302102216.GA13575@elte.hu> References: <20070227103407.GA17819@elte.hu> <20070227105922.GD2250@kernel.dk> <20070227111515.GA4271@kernel.dk> <20070301093450.GA8508@elte.hu> <20070301104117.GA22788@elte.hu> <20070301145204.GA25304@elte.hu> <20070302072100.GB30634@elte.hu> <20070302080441.GA12785@elte.hu> <20070302102018.GA11549@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Daniel Walker , Michal Piotrowski , linux-pm@lists.osdl.org, Linux Kernel Mailing List , Avi Kivity , Adrian Bunk , Pavel Machek , Jens Axboe , "Michael S. Tsirkin" , Thomas Gleixner , Andrew Morton , git@vger.kernel.org To: Linus Torvalds X-From: linux-pm-bounces@lists.osdl.org Fri Mar 02 11:30:27 2007 Return-path: Envelope-to: gll-linux-pm@gmane.org Received: from smtp.osdl.org ([65.172.181.24]) by lo.gmane.org with esmtp (Exim 4.50) id 1HN51t-0000Ia-IV for gll-linux-pm@gmane.org; Fri, 02 Mar 2007 11:30:26 +0100 Received: from fire-2.osdl.org (localhost [127.0.0.1]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id l22ATxAb014367; Fri, 2 Mar 2007 02:30:01 -0800 Received: from mx2.mail.elte.hu (mx2.mail.elte.hu [157.181.151.9]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id l22ATsAb014357 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Fri, 2 Mar 2007 02:29:56 -0800 Received: from elvis.elte.hu ([157.181.1.14]) by mx2.mail.elte.hu with esmtp (Exim) id 1HN51G-0003Fm-GZ from ; Fri, 02 Mar 2007 11:29:49 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id D51463E2141; Fri, 2 Mar 2007 11:29:09 +0100 (CET) Content-Disposition: inline In-Reply-To: <20070302102018.GA11549@elte.hu> User-Agent: Mutt/1.4.2.2i Received-SPF: pass (localhost is always allowed.) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.0.3 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] X-Spam-Status: No, hits=-3.979 required=5 tests=AWL,OSDL_HEADER_LISTID_KNOWN,OSDL_HEADER_SPF_PASS,OSDL_HEADER_SUBJECT_BRACKETED,PATCH_SUBJECT_OSDL X-Spam-Checker-Version: SpamAssassin 2.63-osdl_revision__1.119__ X-MIMEDefang-Filter: osdl$Revision: 1.176 $ X-BeenThere: linux-pm@lists.osdl.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: Linux power management List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org Archived-At: Subject: [patch] KVM: T60 resume fix From: Ingo Molnar my T60 laptop does not resume correctly due to KVM attempting to send an = IPI to a CPU that might be down (or not up yet). (Doing so also triggers = the send_IPI_mask_bitmask() warning in arch/i386/kernel/smp.c, line = 732.) with this fix applied my laptop does not hang during resume. [ KVM will have to disable/enable virtualization on the CPU itself that goes down / comes up, not via an IPI sent from the requesting CPU. ] Signed-off-by: Ingo Molnar --- drivers/kvm/kvm_main.c | 6 ------ 1 file changed, 6 deletions(-) Index: linux/drivers/kvm/kvm_main.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux.orig/drivers/kvm/kvm_main.c +++ linux/drivers/kvm/kvm_main.c @@ -2083,12 +2083,6 @@ static int kvm_cpu_hotplug(struct notifi case CPU_DEAD: case CPU_UP_CANCELED: decache_vcpus_on_cpu(cpu); - smp_call_function_single(cpu, kvm_arch_ops->hardware_disable, - NULL, 0, 1); - break; - case CPU_UP_PREPARE: - smp_call_function_single(cpu, kvm_arch_ops->hardware_enable, - NULL, 0, 1); break; } return NOTIFY_OK;