From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932436AbXCEIcO (ORCPT ); Mon, 5 Mar 2007 03:32:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932408AbXCEIcO (ORCPT ); Mon, 5 Mar 2007 03:32:14 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:45067 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932388AbXCEIcM (ORCPT ); Mon, 5 Mar 2007 03:32:12 -0500 Date: Mon, 5 Mar 2007 09:22:51 +0100 From: Ingo Molnar To: Avi Kivity Cc: Linus Torvalds , Jens Axboe , Pavel Machek , Adrian Bunk , Andrew Morton , Linux Kernel Mailing List , "Michael S. Tsirkin" , Thomas Gleixner , linux-pm@lists.osdl.org, Michal Piotrowski , Daniel Walker , Len Brown , git@vger.kernel.org Subject: Re: [patch] KVM: T60 resume fix Message-ID: <20070305082251.GA23366@elte.hu> References: <20070227111515.GA4271@kernel.dk> <20070301093450.GA8508@elte.hu> <20070301104117.GA22788@elte.hu> <20070301145204.GA25304@elte.hu> <20070302072100.GB30634@elte.hu> <20070302080441.GA12785@elte.hu> <20070302102018.GA11549@elte.hu> <20070302102216.GA13575@elte.hu> <45E93012.4000100@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45E93012.4000100@qumranet.com> User-Agent: Mutt/1.4.2.2i X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.0.3 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Avi Kivity wrote: > > my T60 laptop does not resume correctly due to KVM attempting to > > send an IPI to a CPU that might be down (or not up yet). (Doing so > > also triggers the send_IPI_mask_bitmask() warning in > > arch/i386/kernel/smp.c, line 732.) > > > >with this fix applied my laptop does not hang during resume. > > > >[ KVM will have to disable/enable virtualization on the CPU itself > > that goes down / comes up, not via an IPI sent from the requesting > > CPU. ] > That is already CPU_ONLINE in my tree (and in the pull request sent to > Linus a couple of days ago). that solves the resume problem - but doesnt solve the CPU_DEAD issue of sending an IPI to an already offline CPU. Might be a better idea to do it in CPU_DOWN_PREPARE? (and then to also add a CPU_DOWN_FAILED branch?) Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [patch] KVM: T60 resume fix Date: Mon, 5 Mar 2007 09:22:51 +0100 Message-ID: <20070305082251.GA23366@elte.hu> References: <20070227111515.GA4271@kernel.dk> <20070301093450.GA8508@elte.hu> <20070301104117.GA22788@elte.hu> <20070301145204.GA25304@elte.hu> <20070302072100.GB30634@elte.hu> <20070302080441.GA12785@elte.hu> <20070302102018.GA11549@elte.hu> <20070302102216.GA13575@elte.hu> <45E93012.4000100@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Daniel Walker , Michal Piotrowski , linux-pm@lists.osdl.org, Linux Kernel Mailing List , Adrian Bunk , Pavel Machek , Jens Axboe , "Michael S. Tsirkin" , Thomas Gleixner , Linus Torvalds , Andrew Morton , git@vger.kernel.org To: Avi Kivity X-From: linux-pm-bounces@lists.osdl.org Mon Mar 05 09:31:20 2007 Return-path: Envelope-to: gll-linux-pm@gmane.org Received: from smtp.osdl.org ([65.172.181.24]) by lo.gmane.org with esmtp (Exim 4.50) id 1HO8bH-0003Ma-Ee for gll-linux-pm@gmane.org; Mon, 05 Mar 2007 09:31:19 +0100 Received: from fire-2.osdl.org (localhost [127.0.0.1]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id l258V1q8015073; Mon, 5 Mar 2007 00:31:07 -0800 Received: from mx2.mail.elte.hu (mx2.mail.elte.hu [157.181.151.9]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id l258Usq8015049 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Mon, 5 Mar 2007 00:30:55 -0800 Received: from elvis.elte.hu ([157.181.1.14]) by mx2.mail.elte.hu with esmtp (Exim) id 1HO8ak-0000vD-JH from ; Mon, 05 Mar 2007 09:30:49 +0100 Received: by elvis.elte.hu (Postfix, from userid 1004) id 051F63E2141; Mon, 5 Mar 2007 09:30:45 +0100 (CET) Content-Disposition: inline In-Reply-To: <45E93012.4000100@qumranet.com> User-Agent: Mutt/1.4.2.2i Received-SPF: pass (localhost is always allowed.) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.0.3 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] X-Spam-Status: No, hits=-3.981 required=5 tests=AWL,OSDL_HEADER_LISTID_KNOWN,OSDL_HEADER_SPF_PASS,OSDL_HEADER_SUBJECT_BRACKETED,PATCH_SUBJECT_OSDL X-Spam-Checker-Version: SpamAssassin 2.63-osdl_revision__1.119__ X-MIMEDefang-Filter: osdl$Revision: 1.176 $ X-BeenThere: linux-pm@lists.osdl.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: Linux power management List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org Archived-At: * Avi Kivity wrote: > > my T60 laptop does not resume correctly due to KVM attempting to = > > send an IPI to a CPU that might be down (or not up yet). (Doing so = > > also triggers the send_IPI_mask_bitmask() warning in = > > arch/i386/kernel/smp.c, line 732.) > > > >with this fix applied my laptop does not hang during resume. > > > >[ KVM will have to disable/enable virtualization on the CPU itself = > > that goes down / comes up, not via an IPI sent from the requesting > > CPU. ] > That is already CPU_ONLINE in my tree (and in the pull request sent to = > Linus a couple of days ago). that solves the resume problem - but doesnt solve the CPU_DEAD issue of = sending an IPI to an already offline CPU. Might be a better idea to do = it in CPU_DOWN_PREPARE? (and then to also add a CPU_DOWN_FAILED branch?) Ingo