Re: [PATCH] Remove "decl_subsys_name" macro and single usage of it.

From: Greg KH <greg@kroah.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove "decl_subsys_name" macro and single usage of it.
Date: Thu, 15 Mar 2007 00:25:03 -0700	[thread overview]
Message-ID: <20070315072503.GB8016@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703011205510.20928@CPE00045a9c397f-CM001225dbafb6>

On Thu, Mar 01, 2007 at 12:09:59PM -0500, Robert P. J. Day wrote:
> 
>   Remove the macro "decl_subsys_name" which can be used to declare a
> sysfs subsystem, along with the single invocation of it in the source
> tree, since there appears to be little value in creating a subsystem
> whose subsystem name differs from its structure name.  Everyone else
> just uses "decl_subsys".
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> @@ -800,7 +800,7 @@ MODULE_LICENSE("GPL");
>  module_param(debug, bool, 0644);
>  MODULE_PARM_DESC(debug, "Debugging mode enabled or not");
> 
> -EXPORT_SYMBOL_GPL(pci_hotplug_slots_subsys);
> +EXPORT_SYMBOL_GPL(slots_subsys);

No, don't polute the namespace incorrectly here.  We really want the
variable to still have the "pci_hotplug_" prefix if at all possible.

thanks,

greg k-h