From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974AbXCUQBP (ORCPT ); Wed, 21 Mar 2007 12:01:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752976AbXCUQBP (ORCPT ); Wed, 21 Mar 2007 12:01:15 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:37359 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbXCUQBO (ORCPT ); Wed, 21 Mar 2007 12:01:14 -0400 Date: Wed, 21 Mar 2007 16:00:51 +0000 From: Christoph Hellwig To: Adam Litke Cc: Nick Piggin , Andrew Morton , Arjan van de Ven , William Lee Irwin III , Christoph Hellwig , Ken Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros. Message-ID: <20070321160051.GA5264@infradead.org> Mail-Followup-To: Christoph Hellwig , Adam Litke , Nick Piggin , Andrew Morton , Arjan van de Ven , William Lee Irwin III , Ken Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20070319200502.17168.17175.stgit@localhost.localdomain> <20070319200513.17168.52238.stgit@localhost.localdomain> <4600B216.3010505@yahoo.com.au> <1174490261.21684.13.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1174490261.21684.13.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 21, 2007 at 10:17:40AM -0500, Adam Litke wrote: > > Also, it is going to be hugepage-only, isn't it? So should the naming be > > changed to reflect that? And #ifdef it... > > They are doing some interesting things on Cell that could take advantage > of this. That would be new to me. What we need on Cell is fixing up the get_unmapped_area mess which Ben is working on now. And let me once again repeat that I don't like this at all. I'll rather have a few ugly ifdefs in strategic places than a big object oriented mess like this with just a single user. From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 21 Mar 2007 16:00:51 +0000 From: Christoph Hellwig Subject: Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros. Message-ID: <20070321160051.GA5264@infradead.org> References: <20070319200502.17168.17175.stgit@localhost.localdomain> <20070319200513.17168.52238.stgit@localhost.localdomain> <4600B216.3010505@yahoo.com.au> <1174490261.21684.13.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1174490261.21684.13.camel@localhost.localdomain> Sender: owner-linux-mm@kvack.org Return-Path: To: Adam Litke Cc: Nick Piggin , Andrew Morton , Arjan van de Ven , William Lee Irwin III , Christoph Hellwig , Ken Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Wed, Mar 21, 2007 at 10:17:40AM -0500, Adam Litke wrote: > > Also, it is going to be hugepage-only, isn't it? So should the naming be > > changed to reflect that? And #ifdef it... > > They are doing some interesting things on Cell that could take advantage > of this. That would be new to me. What we need on Cell is fixing up the get_unmapped_area mess which Ben is working on now. And let me once again repeat that I don't like this at all. I'll rather have a few ugly ifdefs in strategic places than a big object oriented mess like this with just a single user. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org