From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 23 Mar 2007 14:26:33 +1100 From: David Gibson To: Scott Wood Subject: Re: [PATCH 05/17] bootwrapper: misc device tree fixes Message-ID: <20070323032633.GE28006@localhost.localdomain> References: <20070316172641.GA29709@ld0162-tx32.am.freescale.net> <20070316172845.GE29784@ld0162-tx32.am.freescale.net> <20070321015104.GC27969@localhost.localdomain> <20070322162239.GA20185@ld0162-tx32.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070322162239.GA20185@ld0162-tx32.am.freescale.net> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Mar 22, 2007 at 11:22:39AM -0500, Scott Wood wrote: > On Wed, Mar 21, 2007 at 12:51:04PM +1100, David Gibson wrote: > > On Fri, Mar 16, 2007 at 12:28:45PM -0500, Scott Wood wrote: > > > 1. The dtb should be generated in $tmpdir, rather than the current directory. > > > Normally, $tmpdir is ".", so it doesn't matter, but the wrapper should obey > > > the -W option if it should be passed. > > > > This is still wrong (or at least insufficient). If we're building > > with a target directory different from the source directory we > > shouldn't add anything to the source directory, but $tmpdir still > > will. > > No, it won't. The current directory is the object directory. I tested > it. Oh, ok. Sorry, my misunderstanding. > The tmpdir thing wasn't to fix that (since it's not broken); it was just > something I'd noticed when I was looking over the script. > > > > 2. DTC has a habit of complaining about errors which are not really > > > errors. Thus, the -f option is now passed to it, to force it to generate > > > output regardless. > > > > I'd really prefer not to add -f by default. I think getting rid of > > the bogus warnings from dtc is a better idea. > > I agree, and have posted a patch to DTC do this. Ok. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson