From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [ANNOUNCE] new new aops patchset Date: Tue, 3 Apr 2007 02:02:18 +0200 Message-ID: <20070403000218.GE12295@wotan.suse.de> References: <20070402120934.GA19626@wotan.suse.de> <1175558171.24533.19.camel@dyn9047017100.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Filesystems , Mark Fasheh , Steven Whitehouse To: Badari Pulavarty Return-path: Received: from ns1.suse.de ([195.135.220.2]:40012 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966120AbXDCACT (ORCPT ); Mon, 2 Apr 2007 20:02:19 -0400 Content-Disposition: inline In-Reply-To: <1175558171.24533.19.camel@dyn9047017100.beaverton.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Apr 02, 2007 at 04:56:11PM -0700, Badari Pulavarty wrote: > On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote: > > Updated aops patchset against 2.6.21-rc5. > > > > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/ > > > > Files/dirs are 2.6.21-rc5-new-aops* > > ext3_write_begin() is computing "start" incorrectly. Good spotting again, thanks! > > Thanks, > Badari > > --- > fs/ext3/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.21-rc5/fs/ext3/inode.c > =================================================================== > --- linux-2.6.21-rc5.orig/fs/ext3/inode.c 2007-04-02 16:06:39.000000000 -0700 > +++ linux-2.6.21-rc5/fs/ext3/inode.c 2007-04-02 16:49:57.000000000 -0700 > @@ -1229,7 +1229,7 @@ static int ext3_write_begin(struct file > unsigned start, end; > > index = pos >> PAGE_CACHE_SHIFT; > - start = pos * (PAGE_CACHE_SIZE - 1); > + start = pos & (PAGE_CACHE_SIZE - 1); > end = start + len; > > retry: >