From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Piggin <npiggin@suse.de>
Subject: Re: [ANNOUNCE] new new aops patchset
Date: Fri, 6 Apr 2007 03:38:07 +0200
Message-ID: <20070406013806.GA32090@wotan.suse.de>
References: <20070402120934.GA19626@wotan.suse.de> <20070404221034.GF21982@ca-server1.us.oracle.com> <1175727919.5019.14.camel@dyn9047017100.beaverton.ibm.com> <20070404231720.GI21982@ca-server1.us.oracle.com> <1175729544.5019.17.camel@dyn9047017100.beaverton.ibm.com> <20070405020803.GB11192@wotan.suse.de> <1175786514.13125.8.camel@dyn9047017100.beaverton.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Mark Fasheh <mark.fasheh@oracle.com>,
	Linux Filesystems <linux-fsdevel@vger.kernel.org>,
	Steven Whitehouse <swhiteho@redhat.com>
To: Badari Pulavarty <pbadari@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:40297 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1767487AbXDFBiM (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 5 Apr 2007 21:38:12 -0400
Content-Disposition: inline
In-Reply-To: <1175786514.13125.8.camel@dyn9047017100.beaverton.ibm.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, Apr 05, 2007 at 08:21:54AM -0700, Badari Pulavarty wrote:
> On Thu, 2007-04-05 at 04:08 +0200, Nick Piggin wrote:
> > 
> > ->readpage can still return AOP_TRUNCATED_PAGE. Were there any from
> > prepare_write or commit_write still around?
> > 
> > 
> 
> Not a big deal. But trying to understand it better.
> 
> 
> int pagecache_write_begin()
> {
>  
>         if (aops->write_begin) {
>                 return aops->write_begin(file, mapping, pos, len, flags,
>                                                         pagep, fsdata);
>         } else {
>                 .....
>                 ret = aops->readpage(file, page);
>                 page_cache_release(page);
>                 if (ret) {
> 			if (ret == AOP_TRUNCATED_PAGE)
>                                         goto again;
>                         return ret;
>                 }
>                 goto again;
> 		
> 	      ....
> 	}
> }
> 
> filesystems (ocfs2, gfs2) which can return AOP_TRUNCATED_PAGE for
> prepare_write or readpage would never come to this case. They
> have write_begin() method set. Isn't it ? Why this check ?

Ah you're right. In that case, I'll replace that with a comment ;)

Thanks!