All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@clusterfs.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Jim Garlick <garlick@llnl.gov>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs - pass1c terminates early if hard links
Date: Tue, 10 Apr 2007 22:22:20 -0600	[thread overview]
Message-ID: <20070411042220.GP5967@schatzie.adilger.int> (raw)
In-Reply-To: <20070411034019.GA25231@thunk.org>

On Apr 10, 2007  23:40 -0400, Theodore Tso wrote:
> Also note that providing a
> script which generates the test filesystem is now preferred to
> including an image.gz file; it avoids the need for binary patches, and
> it makes it clearer how the test filesystem is constructed.

Agreed, though in some cases it is considerably easier to produce the
corruption via binary editing than debugfs commands unless there are
now facilities to copy blocks/bytes around within the filesystem?

> +find all directdory pathnames

Typo.

> diff -r 365efb1a2299 -r 8bb7637c6508 tests/f_dup4/script
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/tests/f_dup4/script	Tue Apr 10 22:55:09 2007 -0400
> @@ -0,0 +1,50 @@
> +set_inode_field /dir/foo block[0] 30
> +set_inode_field /dir2/bar block[0] 30
> +set_inode_field /dir3/baz block[0] 30
> +set_inode_field /dir/fee block[0] 34
> +set_inode_field /dir2/fie block[0] 34
> +set_inode_field /dir3/foe block[0] 34

Also, items such as these presuppose that the directory has specific
blocks allocated to it, which need the test case to be constructed in
multiple passes (to extract these numbers) and could break at some time 
in the future.


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

  reply	other threads:[~2007-04-11  4:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-10 20:51 [PATCH] e2fsprogs - pass1c terminates early if hard links Jim Garlick
2007-04-10 22:39 ` [PATCH] e2fsprogs - e2fsck pass1c does extra work if root dir has shared blocks Jim Garlick
2007-04-20 12:14   ` Theodore Tso
2007-04-11  3:40 ` [PATCH] e2fsprogs - pass1c terminates early if hard links Theodore Tso
2007-04-11  4:22   ` Andreas Dilger [this message]
2007-04-11 10:42     ` Theodore Tso
2007-04-11 11:51       ` Andreas Dilger
2007-04-11 12:57         ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070411042220.GP5967@schatzie.adilger.int \
    --to=adilger@clusterfs.com \
    --cc=garlick@llnl.gov \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.