From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ladislav Michl Date: Wed, 16 May 2007 12:27:39 +0200 Subject: [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info In-Reply-To: <463A4EC8.9080301@orkun.us> References: <20070323115235.GA4857@michl.2n.cz> <20070424102648.GA18388@michl.2n.cz> <463907B8.3060104@orkun.us> <20070503100453.GA5146@michl.2n.cz> <463A4EC8.9080301@orkun.us> Message-ID: <20070516102739.GA5782@michl.2n.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, May 03, 2007 at 04:06:16PM -0500, Tolunay Orkun wrote: > I was referring to the frequency of the use of the function during flash > programming. I am use it is called elsewhere but when the function is in > the same file compiler has more opportunities to optimize. That is why I > prefer the function stay in the flash driver and exported from there. In drivers/cfi_flash.c flash_get_info (alias addr2info) is called only from flash_init. So what "frequency of the use" are you referring to? There is not only CFI driver, some boards have their own flash drivers. Do you want them to provide another variant of this function? Or use the one from flash.c? Why cannot cfi_flash.c use it as well? Just try to run grep -r addr2info ... Best regards, ladis