All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info
Date: Wed, 16 May 2007 12:45:55 +0200	[thread overview]
Message-ID: <200705161245.55933.sr@denx.de> (raw)
In-Reply-To: <20070516102739.GA5782@michl.2n.cz>

On Wednesday 16 May 2007, Ladislav Michl wrote:
> On Thu, May 03, 2007 at 04:06:16PM -0500, Tolunay Orkun wrote:
> > I was referring to the frequency of the use of the function during flash
> > programming. I am use it is called elsewhere but when the function is in
> > the same file compiler has more opportunities to optimize. That is why I
> > prefer the function stay in the flash driver and exported from there.
>
> In drivers/cfi_flash.c flash_get_info (alias addr2info) is called only from
> flash_init. So what "frequency of the use" are you referring to? There
> is not only CFI driver, some boards have their own flash drivers. Do you
> want them to provide another variant of this function? Or use the one
> from flash.c? Why cannot cfi_flash.c use it as well?

Sounds reasonable to me. Just me 2 cents.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2007-05-16 10:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-23 11:52 [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info Ladislav Michl
2007-03-24 18:27 ` [U-Boot-Users] u-boot.lds Charles Krinke
2007-03-25 20:38   ` Wolfgang Denk
2007-04-24 10:26 ` [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info Ladislav Michl
2007-05-02 21:50   ` Tolunay Orkun
2007-05-03 10:04     ` Ladislav Michl
2007-05-03 21:06       ` Tolunay Orkun
2007-05-16 10:27         ` Ladislav Michl
2007-05-16 10:45           ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705161245.55933.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.