From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HsgHG-0001on-MZ
	for qemu-devel@nongnu.org; Mon, 28 May 2007 10:32:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HsgHF-0001mR-07
	for qemu-devel@nongnu.org; Mon, 28 May 2007 10:32:54 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HsgHE-0001mG-SD
	for qemu-devel@nongnu.org; Mon, 28 May 2007 10:32:52 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1HsgHE-0003l4-Ca
	for qemu-devel@nongnu.org; Mon, 28 May 2007 10:32:52 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] qemu/linux-user syscall.c
Date: Mon, 28 May 2007 15:28:00 +0100
References: <E1Hsfqv-0003Qv-HG@cvs>
In-Reply-To: <E1Hsfqv-0003Qv-HG@cvs>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200705281528.01875.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> 	Fix do_socketcall argument, by Daniel Jacobowitz.

> -  static long do_socketcall(int num, target_ulong vptr)   
> +  static long do_socketcall(int num, target_phys_addr_t vptr) 

What is this supposed to be fixing?
vptr is a target pointer, and is only ever used as an argument to tgetl.
I think the original type (target_ulong) is correct.

target_phys_addr_t isn't really meaningful for userspace emulation.
We don't have physical addresses, only target (target_ulong) and
host (void *) virtual addresses.

Paul