From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HslVi-0002EZ-Er
	for qemu-devel@nongnu.org; Mon, 28 May 2007 16:08:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HslVe-0002DI-Tl
	for qemu-devel@nongnu.org; Mon, 28 May 2007 16:08:10 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HslVe-0002DB-P3
	for qemu-devel@nongnu.org; Mon, 28 May 2007 16:08:06 -0400
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1HslVe-0003HZ-AR
	for qemu-devel@nongnu.org; Mon, 28 May 2007 16:08:06 -0400
Date: Mon, 28 May 2007 21:08:04 +0100
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] qemu/linux-user syscall.c
Message-ID: <20070528200804.GC16556@networkno.de>
References: <E1Hsfqv-0003Qv-HG@cvs> <200705281528.01875.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200705281528.01875.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

Paul Brook wrote:
> > 	Fix do_socketcall argument, by Daniel Jacobowitz.
> 
> > -  static long do_socketcall(int num, target_ulong vptr)   
> > +  static long do_socketcall(int num, target_phys_addr_t vptr) 
> 
> What is this supposed to be fixing?
> vptr is a target pointer, and is only ever used as an argument to tgetl.
> I think the original type (target_ulong) is correct.
> 
> target_phys_addr_t isn't really meaningful for userspace emulation.
> We don't have physical addresses, only target (target_ulong) and
> host (void *) virtual addresses.

Reverted. I had it for so long in my local tree I forgot its purpose. :-)


Thiemo