From: David Miller <davem@davemloft.net>
To: matthew@wil.cx
Cc: linux-scsi@vger.kernel.org
Subject: Re: An MCA ESP driver
Date: Wed, 15 Aug 2007 14:55:51 -0700 (PDT) [thread overview]
Message-ID: <20070815.145551.78731552.davem@davemloft.net> (raw)
In-Reply-To: <20070815172600.GF16277@parisc-linux.org>
From: Matthew Wilcox <matthew@wil.cx>
Date: Wed, 15 Aug 2007 11:26:00 -0600
> On Tue, Aug 07, 2007 at 12:26:04AM -0700, David Miller wrote:
> > > - struct sbus_dma *dma;
> > > + union {
> > > + struct sbus_dma *sbus_dma;
> > > + unsigned int x86_dma;
> > > + };
> > > };
> >
> > Feel free to make this a "void *dma_cookie" or similar.
> > It's private to the bus front-end.
>
> Hi Dave,
>
> Could I just clarify; would you prefer it to be a void *? I prefer the
> anonymous union that I have there right now, but I'm not particularly
> attached to it. In particular, I don't really care to be casting ints
> (x86) to pointers, but that's a matter of personal taste.
Alternatively, you could remove this member entirely, and
make the front-end driver allocate a private area at the
end of "struct esp" to use for whatever purpose it likes.
I'm mostly ambivalent, but if the member stays it should be
some generic type rather than anything front-end specific
like it is now.
next prev parent reply other threads:[~2007-08-15 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 23:24 An MCA ESP driver Matthew Wilcox
2007-08-07 7:26 ` David Miller
2007-08-15 17:26 ` Matthew Wilcox
2007-08-15 21:55 ` David Miller [this message]
2008-01-05 21:18 ` James Bottomley
2008-01-05 21:53 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070815.145551.78731552.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.