From: Jan Kara <jack@suse.cz>
To: linux-ext4@vger.kernel.org
Cc: Takashi Sato <sho@tnes.nec.co.jp>
Subject: Avoid rec_len overflow with 64KB block size
Date: Thu, 20 Sep 2007 16:32:14 +0200 [thread overview]
Message-ID: <20070920143214.GC1986@atrey.karlin.mff.cuni.cz> (raw)
Hello,
when converting ext4 directories to pagecache I just came over
Takashi's patch preventing overflowing of rec_len. Looking over the
patch - can't we do it more elegantly by using say 0xffff instead of 64K
and perform conversion (using some helper) at the moment we read / store
rec_len? That would be IMHO more transparent than current approach (at
least it took me some time to understand what's going on with the
current patch when I was looking at the code)...
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
next reply other threads:[~2007-09-20 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 14:32 Jan Kara [this message]
2007-09-20 16:17 ` Avoid rec_len overflow with 64KB block size Jan Kara
2007-09-20 18:18 ` Andreas Dilger
2007-09-21 13:38 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070920143214.GC1986@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sho@tnes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.