Re: LSI Logic 40919o fibre channel: scsi works ip not

[Mario Giammarco <mgiammarco-ml@4warding.com>]

Il Monday 05 March 2007 20:46:10 Shirron, Stephen ha scritto:
> The code should look like this, in mpt_lan_post_receive_buckets():
>
> 			goto out;
> 		}
> 		pRecvReq = (LANReceivePostRequest_t *) mf;
>
> 		i = le16_to_cpu(mf->u.frame.hwhdr.msgctxu.fld.req_idx);
> 		mpt_dev->RequestNB[i] = 0;
>
> 		count = buckets;
> 		if (count > max)
> 			count = max;
>
> If you send me mptlan.c, I will edit it for you.  Then there cannot
> be a mistake.
>
> stephen
>
> -----Original Message-----
> From: Mario Giammarco [mailto:mgiammarco@gmail.com]
> Sent: Monday, March 05, 2007 2:39 PM
> To: Shirron, Stephen
> Cc: Mario Giammarco; Hickerson, Roger
> Subject: Re: LSI Logic 40919o fibre channel: scsi works ip not
>
> Sorry for delay replying. I have seen kernel 2.6.18 and 2.6.20 source
> and these lines are missinig:
>
>    i = le16_to_cpu(mf->u.frame.hwhdr.msgctxu.fld.req_idx);
>                 mpt_dev->RequestNB[i] = 0;
>
> I do not understand where to put them. Perhaps inside the for loop (i
> is the loop variable...) but I do not understand if I can choose a
> random point or I have to put it in a specific place.
>
> Thanks again for interest!
>
>
> 2007/2/16, Shirron, Stephen <Stephen.Shirron@lsi.com>:
> Mario,
>
> There appears to be a bug in the driver.
>
> Go to mpt_lan_post_receive_buckets(), in mptlan.c.  Find:
>
>                 mf = mpt_get_msg_frame(LanCtx, mpt_dev);
>
> Later find:
>
>                 pRecvReq = (LANReceivePostRequest_t *) mf;
>
> Below that, should be:
>
>                 i = le16_to_cpu(mf->u.frame.hwhdr.msgctxu.fld.req_idx);
>                 mpt_dev->RequestNB[i] = 0;
>
> The above two lines of code are present in some versions of mptctl.c
> (the 2.06.xx versions and 3.02.xx versions) but are missing from some
> others (3.03.xx, 3.04.xx, and 4.00.xx).
>
> If you can add those two lines of code, rebuild mptctl.ko, and retest,
> I believe that should take care of your reported problems.
>
> Let me know, please.
>
> stephen


Hello,
month ago I replied to you saying that this patch solved my bug.

Today I am trying kernel 2.6.22 and I see that it does not contain yet the 
patch.

Can you please put the patch in official driver?

Thank you very much!

Mario Giammarco