From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753285AbbL2OLq (ORCPT ); Tue, 29 Dec 2015 09:11:46 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:50637 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbbL2OLm convert rfc822-to-8bit (ORCPT ); Tue, 29 Dec 2015 09:11:42 -0500 From: Arnd Bergmann To: Rongrong Zou Cc: Rongrong Zou , minyard@acm.org, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will.deacon@arm.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, lijianhua@huawei.com Subject: Re: [PATCH v1 2/3] ARM64 LPC: LPC driver implementation Date: Tue, 29 Dec 2015 15:11:07 +0100 Message-ID: <2007093.hGYRGHCjMe@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <568292A2.9040708@huawei.com> References: <1451396032-23708-1-git-send-email-zourongrong@gmail.com> <1557466.ZWCBjbTVg8@wuerfel> <568292A2.9040708@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:STu7pGw22RD3WsNQ1yJ5iZfXncQfgOIPpzisrM6nDltxYSyL6X6 Bcw2boDSx6wtTXdHO+YXqgAeXHljTl9Xu7RKaaLp0HN4bLGxUUlZKN+nY/fbreQ1jV9EtGr K5QLWT1pnSttAV/ndWeYCL5rE1o7X2PP6eUOmOFF+nyrFjGzB36JpaOuH63DthBum4KTbQ/ RkTdlyCxlWAPlqZhlfI3A== X-UI-Out-Filterresults: notjunk:1;V01:K0:4tM9kbzk7bY=:YV1b5G29LM4vOFlyEyiVix YGQfKQz3uhMNbRGn2i3575IwSriZMZ+30Ez/yFHLCDY/Zh6AuDRE8GNqz5yA6c1q+zL8i18fI UpADBIKJLifot/4yQlKlmQUCxbds5xAPNCyMigqzyOh6wLIGSLJzXOmoALZ2W8lBG/QgqGnV4 y9KWzvaGTNZy7VVnTgVXZwbdn+VPux9VXZQs9vP9/YqBv99muMpIPIDIu3a8juaQRO+gVMbPd 5h3Vh/iaYaCD0IVHKDynXX1xAoF+Se9urlohdan9VXr5KYD/pZYkRi4fz72VV+cVvCR/cXSrw a2KOck9eEI5VeDfK1gSyCnzrAtCUv9RxXn88RnlMUL20czEq0OaAGAHFe0IyrJLFKSrQ8ObnP WmbwktkdKggsPwv5gW/gZPNgnqytG2rH2UfYxWl0fFtSrT+5b2heHMvu8oqEHwbzlVF2dICS2 aqkmYf4LACXPnGdD5EqKX9rLkxGnLOQtV695BskY9e7rwRRTTTOrhzJHWVwizkgk3pw9smiFQ rw7NuAUtvlKY3rVbeQLQmoWqw0wGbdoi4oUfT7CjY8goYCL9/96LYPYQ1R2Jmfw2Q7ShuJv8+ SiSQqat7JlCx5n31iSP5/szB7VmnCVGqSwOQQI2IProsq/mdE6zLs0cvcIJHtxze+ZprJfpW7 bpthqA9JvqnUV5236/CHqJ9+uYR9YCHsiz+M2TmdbZGpI+TCcH6B5LKx8It+Sp9Fg3+R1HME/ 9awxJvbjztHkQAoT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 29 December 2015 22:03:14 Rongrong Zou wrote: > 在 2015/12/29 21:51, Arnd Bergmann 写道: > > On Tuesday 29 December 2015 21:33:51 Rongrong Zou wrote: > >> We only implement io cycles here, we hook the lpc_io_write_byte > >> and lpc_io_read_byte to inb/outb. So the drivers(ipmi/uart) which access > >> the legacy ISA I/O port need no modification. > >> > >> The low pin count specification is at > >> http://www.intel.com/design/chipsets/industry/lpc.htm > >> > >> Signed-off-by: Rongrong Zou > > > > I'm slightly confused here: I thought this driver was hisilicon specific. > > Is the MMIO register layout that is used in this hardware actually standardized > > in a way that the driver also works for all other implementations? > > The register defined is not standardized. other vendors may define their own > registers. Ok, please clarify this in the patch description, the Kconfig help text and the DT binding then. Arnd