From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver Date: Fri, 14 Dec 2007 10:33:05 -0600 Message-ID: <20071214163305.GA3704@lixom.net> References: <20071204170442.GA10460@localhost.localdomain> <20071204170719.GB15599@localhost.localdomain> <20071204184826.GA5758@lixom.net> <20071204194921.GB1253@localhost.localdomain> <20071204200121.GA6782@lixom.net> <20071205004841.GA25905@linux-sh.org> <20071205183912.GA4516@loki.buserror.net> <20071214082313.GA28118@lixom.net> <20071214160928.GA16607@ld0162-tx32.am.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from lixom.net ([66.141.50.11]:49929 "EHLO mail.lixom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753768AbXLNQ1e (ORCPT ); Fri, 14 Dec 2007 11:27:34 -0500 Content-Disposition: inline In-Reply-To: <20071214160928.GA16607@ld0162-tx32.am.freescale.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Scott Wood Cc: linux-ide@vger.kernel.org, Paul Mundt , Arnd Bergmann , Jeff Garzik , linuxppc-dev@ozlabs.org On Fri, Dec 14, 2007 at 10:09:28AM -0600, Scott Wood wrote: > On Fri, Dec 14, 2007 at 02:23:13AM -0600, Olof Johansson wrote: > > On Wed, Dec 05, 2007 at 12:39:12PM -0600, Scott Wood wrote: > > > Why is it dependent on anything other than platform bus support and ATA? > > > > There's no way to specify dependency on platform bus as a config option, > > that's likely what EMBEDDED was meant to do. Some platforms have platform > > bus in spite of being !EMBEDDED, arch/arm/configs/rpc_defconfig seems > > to be among those. PPC too. > > If platform bus can't be configged out, then the only dependency should > be the implicit one on ATA (is there anything else whose absence will > stop the code from building, or working if the appropriate platform > device is passed in?). Sure, sounds good to me. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lixom.net (lixom.net [66.141.50.11]) by ozlabs.org (Postfix) with ESMTP id 3BBFCDDE17 for ; Sat, 15 Dec 2007 03:27:35 +1100 (EST) Date: Fri, 14 Dec 2007 10:33:05 -0600 From: Olof Johansson To: Scott Wood Subject: Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver Message-ID: <20071214163305.GA3704@lixom.net> References: <20071204170442.GA10460@localhost.localdomain> <20071204170719.GB15599@localhost.localdomain> <20071204184826.GA5758@lixom.net> <20071204194921.GB1253@localhost.localdomain> <20071204200121.GA6782@lixom.net> <20071205004841.GA25905@linux-sh.org> <20071205183912.GA4516@loki.buserror.net> <20071214082313.GA28118@lixom.net> <20071214160928.GA16607@ld0162-tx32.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20071214160928.GA16607@ld0162-tx32.am.freescale.net> Cc: linux-ide@vger.kernel.org, Paul Mundt , Jeff Garzik , Arnd Bergmann , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Dec 14, 2007 at 10:09:28AM -0600, Scott Wood wrote: > On Fri, Dec 14, 2007 at 02:23:13AM -0600, Olof Johansson wrote: > > On Wed, Dec 05, 2007 at 12:39:12PM -0600, Scott Wood wrote: > > > Why is it dependent on anything other than platform bus support and ATA? > > > > There's no way to specify dependency on platform bus as a config option, > > that's likely what EMBEDDED was meant to do. Some platforms have platform > > bus in spite of being !EMBEDDED, arch/arm/configs/rpc_defconfig seems > > to be among those. PPC too. > > If platform bus can't be configged out, then the only dependency should > be the implicit one on ATA (is there anything else whose absence will > stop the code from building, or working if the appropriate platform > device is passed in?). Sure, sounds good to me. -Olof