From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397AbYAZH0N (ORCPT ); Sat, 26 Jan 2008 02:26:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751770AbYAZHZ6 (ORCPT ); Sat, 26 Jan 2008 02:25:58 -0500 Received: from 8bytes.org ([88.198.83.132]:60605 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbYAZHZ6 (ORCPT ); Sat, 26 Jan 2008 02:25:58 -0500 Date: Sat, 26 Jan 2008 08:25:56 +0100 From: Joerg Roedel To: "Nakajima, Jun" Cc: Joerg Roedel , Avi Kivity , kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging Message-ID: <20080126072556.GB21476@8bytes.org> References: <1201294393-22613-1-git-send-email-joerg.roedel@amd.com> <1201294393-22613-4-git-send-email-joerg.roedel@amd.com> <2D848F959C03D945A84E9EDE7F7BFE4274021D@orsmsx424.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2D848F959C03D945A84E9EDE7F7BFE4274021D@orsmsx424.amr.corp.intel.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 25, 2008 at 05:47:11PM -0800, Nakajima, Jun wrote: > Joerg Roedel wrote: > > To disable the use of the Nested Paging feature even if it is > available in > > hardware this patch adds a module parameter. Nested Paging can be > disabled by > > passing npt=off to the kvm_amd module. > > I think it's better to use a (common) parameter to qemu. That way you > can control on/off for each VM. Generally I see no problem with it. But at least for NPT I don't see a reason why someone should want to disable it on a VM basis (as far as it works stable). Avi, what do you think? Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 3/8] SVM: add module parameter to disable NestedPaging Date: Sat, 26 Jan 2008 08:25:56 +0100 Message-ID: <20080126072556.GB21476@8bytes.org> References: <1201294393-22613-1-git-send-email-joerg.roedel@amd.com> <1201294393-22613-4-git-send-email-joerg.roedel@amd.com> <2D848F959C03D945A84E9EDE7F7BFE4274021D@orsmsx424.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Avi Kivity To: "Nakajima, Jun" Return-path: Content-Disposition: inline In-Reply-To: <2D848F959C03D945A84E9EDE7F7BFE4274021D-7XlYjKTK0pM64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Fri, Jan 25, 2008 at 05:47:11PM -0800, Nakajima, Jun wrote: > Joerg Roedel wrote: > > To disable the use of the Nested Paging feature even if it is > available in > > hardware this patch adds a module parameter. Nested Paging can be > disabled by > > passing npt=off to the kvm_amd module. > > I think it's better to use a (common) parameter to qemu. That way you > can control on/off for each VM. Generally I see no problem with it. But at least for NPT I don't see a reason why someone should want to disable it on a VM basis (as far as it works stable). Avi, what do you think? Joerg ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/