From: Dmitry Potapov <dpotapov@gmail.com>
To: Jay Soffian <jaysoffian+git@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Improve git-help--browse browser support under OS X
Date: Sun, 10 Feb 2008 15:43:36 +0300 [thread overview]
Message-ID: <20080210124336.GH30368@dpotapov.dyndns.org> (raw)
In-Reply-To: <76718490802091815s45c19113t938f5257aad3f46c@mail.gmail.com>
On Sat, Feb 09, 2008 at 09:15:30PM -0500, Jay Soffian wrote:
>
> I guess I'm confused by the criticism as I thought that's what I did.
> "open" is only added to the list of browsers to try if the
> SECURITYSESSIONID environment variable is set (indicating an OS X GUI
> login environment). I don't see how the change I made could adversely
> impact the users of other systems.
Would not be better to use uname instead like this
if test "$(uname -s)" == "Darwin"; then
...
or in addition to SECURITYSESSIONID:
if test -n "$SECURITYSESSIONID" -a "$(uname -s)" == "Darwin"; then
...
?
I think it would be more reliable and more importantly it makes the
code easier to understand, because it is clear now for everyone that
this is OS X specific.
BTW, should not it be mentioned in the documentation? Probably, in
the list of supported web browsers in git-help.txt.
Dmitry
next prev parent reply other threads:[~2008-02-10 12:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 21:23 [PATCH] Improve git-help--browse browser support under OS X jaysoffian+git
2008-02-09 20:20 ` Dmitry Potapov
2008-02-10 2:15 ` Jay Soffian
2008-02-10 12:43 ` Dmitry Potapov [this message]
2008-02-10 13:45 ` Christian Couder
2008-02-11 2:13 ` Jay Soffian
2008-02-11 5:03 ` Christian Couder
2008-02-11 2:10 ` Jay Soffian
2008-02-11 2:24 ` [PATCH] git-web--browse: improve " jaysoffian+git
2008-02-11 3:01 ` Junio C Hamano
2008-02-11 14:15 ` Jay Soffian
2008-02-12 16:40 ` Jay Soffian
2008-02-13 6:55 ` Christian Couder
2008-02-13 22:14 ` Junio C Hamano
2008-02-13 22:46 ` Pieter de Bie
2008-02-14 0:13 ` Jay Soffian
2008-02-14 5:09 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210124336.GH30368@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian+git@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.