From: Ingo Molnar <mingo@elte.hu>
To: Stefan Assmann <sassmann@suse.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Jon Masters <jonathan@jonmasters.org>, Olaf Dabrunz <od@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
Ihno Krumreich <ihno@suse.de>, Sven Dietrich <sdietrich@suse.de>,
Daniel Gollub <dgollub@suse.de>,
Felix Foerster <ffoerster@suse.de>
Subject: Re: [PATCH 0/5] Boot IRQ quirks and rerouting [repost]
Date: Wed, 18 Jun 2008 14:52:27 +0200 [thread overview]
Message-ID: <20080618125227.GA20056@elte.hu> (raw)
In-Reply-To: <20080618115819.GA13714@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> * Stefan Assmann <sassmann@suse.de> wrote:
>
> > These patches are against linux-2.6-tip, auto-x86-next.
> >
> > The AMD/ATI and Broadcomm patches are not included yet, we're working
> > on getting things ready for submission.
> >
> > The patch for the bootirqquirk= parameter will be released later.
>
> applied, thanks Stefan. I have created a new
> tip/x86/pci-ioapic-boot-irq-quirks topic branch for this. Lets see how
> these changes work out in practice.
-tip testing found the following build failure:
init/built-in.o: In function `nosmp':
main.c:(.init.text+0x14): undefined reference to `noioapicquirk'
main.c:(.init.text+0x1e): undefined reference to `noioapicreroute'
init/built-in.o: In function `maxcpus':
main.c:(.init.text+0x133): undefined reference to `noioapicquirk'
main.c:(.init.text+0x13d): undefined reference to `noioapicreroute'
arch/x86/kernel/built-in.o: In function `parse_noapic':
io_apic_32.c:(.init.text+0x7836): undefined reference to `noioapicquirk'
io_apic_32.c:(.init.text+0x7840): undefined reference to `noioapicreroute'
with this config:
http://redhat.com/~mingo/misc/config-Wed_Jun_18_14_23_24_CEST_2008.bad
fixed via the patch below.
Ingo
--------->
commit 7c01f5c8fc734cfbbdad3b389b88e1aa12c78e5b
Author: Ingo Molnar <mingo@elte.hu>
Date: Wed Jun 18 14:47:09 2008 +0200
x86: boot IRQ quirks and rerouting, fix
fix:
init/built-in.o: In function `nosmp':
main.c:(.init.text+0x14): undefined reference to `noioapicquirk'
main.c:(.init.text+0x1e): undefined reference to `noioapicreroute'
init/built-in.o: In function `maxcpus':
main.c:(.init.text+0x133): undefined reference to `noioapicquirk'
main.c:(.init.text+0x13d): undefined reference to `noioapicreroute'
arch/x86/kernel/built-in.o: In function `parse_noapic':
io_apic_32.c:(.init.text+0x7836): undefined reference to `noioapicquirk'
io_apic_32.c:(.init.text+0x7840): undefined reference to `noioapicreroute'
Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/include/asm-x86/io_apic.h b/include/asm-x86/io_apic.h
index 5f68b1d..3086c26 100644
--- a/include/asm-x86/io_apic.h
+++ b/include/asm-x86/io_apic.h
@@ -157,8 +157,10 @@ extern int timer_through_8259;
static inline void disable_ioapic_setup(void)
{
+#ifdef CONFIG_PCI
noioapicquirk = 1;
noioapicreroute = -1;
+#endif
skip_ioapic_setup = 1;
}
next prev parent reply other threads:[~2008-06-18 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 14:35 [PATCH 0/5] Boot IRQ quirks and rerouting [repost] Stefan Assmann
2008-06-11 14:35 ` [PATCH 1/5] Add PCI IDs for devices that need boot irq quirks Stefan Assmann
2008-06-11 14:35 ` [PATCH 2/5] Introduce pci=noioapicquirk kernel cmdline option Stefan Assmann
2008-06-11 14:35 ` [PATCH 3/5] Introduce pci=ioapicreroute " Stefan Assmann
2008-06-11 14:35 ` [PATCH 4/5] Add quirk to disable boot interrupt generation on intel 6300ESB Stefan Assmann
2008-06-11 14:35 ` [PATCH 5/5] reroute PCI interrupt to legacy boot interrupt equivalent Stefan Assmann
2008-06-18 11:58 ` [PATCH 0/5] Boot IRQ quirks and rerouting [repost] Ingo Molnar
2008-06-18 12:52 ` Ingo Molnar [this message]
2008-06-18 13:22 ` Olaf Dabrunz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618125227.GA20056@elte.hu \
--to=mingo@elte.hu \
--cc=dgollub@suse.de \
--cc=ffoerster@suse.de \
--cc=hpa@zytor.com \
--cc=ihno@suse.de \
--cc=jonathan@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@suse.de \
--cc=sassmann@suse.de \
--cc=sdietrich@suse.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.