Re: [PATCH 01/15] kmemleak: Add the base support

From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 01/15] kmemleak: Add the base support
Date: Mon, 01 Dec 2008 14:39:03 +0900	[thread overview]
Message-ID: <20081201142824.D552.E1E9C6FF@jp.fujitsu.com> (raw)
In-Reply-To: <20081129104312.16726.36218.stgit@pc1117.cambridge.arm.com>

Hello.

I have a question. (may be silly)

> +/*
> + * Insert a pointer into the pointer hash table.
> + */
> +static inline void create_object(unsigned long ptr, size_t size, int ref_count)
> +{
> +	unsigned long flags;
> +	struct memleak_object *object;
> +	struct prio_tree_node *node;
> +	struct stack_trace trace;
> +
> +	object = kmem_cache_alloc(object_cache, GFP_ATOMIC);
> +	if (!object)
> +		panic("kmemleak: cannot allocate a memleak_object structure\n");

IIRC, GFP_ATOMIC allocation sometimes fails. (ex. when page cache occupies all
area). It seems to be easy to panic. Is it intended? 

Thanks.
-- 
Yasunori Goto 