Re: [PATCH 1/1] Userspace I/O (UIO): Add support for userspace DMA

From: Greg KH <gregkh@suse.de>
To: edward_estabrook@agilent.com
Cc: linux-kernel@vger.kernel.org, hjk@linutronix.de,
	edward.estabrook@gmail.com, edward.estabrook.lkml@gmail.com
Subject: Re: [PATCH 1/1] Userspace I/O (UIO): Add support for userspace DMA
Date: Wed, 3 Dec 2008 16:50:55 -0800	[thread overview]
Message-ID: <20081204005055.GE6981@suse.de> (raw)
In-Reply-To: <43FC624C55D8C746A914570B66D642610367F29B@cos-us-mb03.cos.agilent.com>

On Wed, Dec 03, 2008 at 02:39:44PM -0700, edward_estabrook@agilent.com wrote:
> @@ -82,6 +94,16 @@ static inline int __must_check  extern void uio_unregister_device(struct uio_info *info);  extern void uio_event_notify(struct uio_info *info);
>  
> +/* uio_dev_get_name - return the name associated with this uio device 
> +*/ extern char *uio_dev_get_name(struct uio_device *idev);
> +
> +/* Starting index assigned to dynamically allocated regions. */ #define 
> +UIO_DMA_MEM_BASE_INDEX 1000
> +
> +/* mmap dynamically allocates a DMA memory block if
> + * its offset parameter matches this value. */ #define 
> +UIO_DMA_MEM_ALLOCATE_VM_PGOFF_MAGIC 0xFFFFFUL

Something looks wrong with this patch, is it line wrapped somehow?

odd.

thanks,

greg k-h