From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] x86: fix the potential of encountering panic "IO-APIC+ timer doesn't work! ..." Date: Fri, 12 Dec 2008 11:06:38 +0100 Message-ID: <20081212100638.GC18152@elte.hu> References: <4940FBFA.76E4.0078.0@novell.com> <20081212091329.GG25106@elte.hu> <49424210.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <49424210.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org * Jan Beulich wrote: > >>> Ingo Molnar 12.12.08 10:13 >>> > > > >* Jan Beulich wrote: > > > >> >From all I can tell, the below reproduced full description of the > >> original Linux patch applies to Xen, too - at least in the watchdog > >> enabled case IRQs can be enabled when entering setup_IO_APIC(). My > >> attention to this change really got caught just by the fact that it got > >> added to our (2.6.16-based) SLE10 kernel pretty recently. > > > >note that we had to revert that eventually. The real solution is an > >array of fixes from Maciej spread out over many months. > > What do you mean by 'eventually'? 2.6.28-rc8 still has this code, and > so does -tip. argh. Different io-apic breakage. I shouldnt remember patches by their subject lines ;-) Sorry about the confusion - Jan is right and my fix ported to Xen is good ;-) the point about the other breakages remains: for the best bootup ratio you'll want to pick up everything from the (now unified) arch/x86/kernel/io_apic.c. Ingo