All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Schilling Landgraf <dougsland@gmail.com>
To: Robert William Fuller <hydrologiccycle@gmail.com>
Cc: "video4linux-list@redhat.com" <video4linux-list@redhat.com>
Subject: Re: [REVIEW PATCH 13/14] OMAP: CAM: Add Lens Driver
Date: Fri, 12 Dec 2008 10:25:29 -0200	[thread overview]
Message-ID: <20081212102529.77b4e105@gmail.com> (raw)
In-Reply-To: <49422453.8080000@gmail.com>

Hello Robert,

On Fri, 12 Dec 2008 03:44:03 -0500
Robert William Fuller <hydrologiccycle@gmail.com> wrote:

> Alexey Klimov wrote:
> 
> <snip>
> 
>  > I didn't ever see two "=" in one line in code. Is it okay ?
> 
> If you do not understand the C programming language, why are you in a 
> position to review code?

humm, everyone can review patches and give their opinions.
The technique of reviewing code will always help programmers to
improve their knowledge and helps the quality of modules or even
of subsystem. On the other hand, if the author of patch or maintainer
will accept those suggestions is other case.

IMO, the above answer discourage reviewing code, please
don't do that again.

Cheers,
Douglas

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-12-12 12:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 20:38 [REVIEW PATCH 13/14] OMAP: CAM: Add Lens Driver Aguirre Rodriguez, Sergio Alberto
2008-12-12  6:03 ` Alexey Klimov
2008-12-12  6:03   ` Alexey Klimov
2008-12-12  8:44   ` Robert William Fuller
2008-12-12 12:25     ` Douglas Schilling Landgraf [this message]
2008-12-16 20:24   ` Aguirre Rodriguez, Sergio Alberto
2008-12-16 17:38 ` Hans Verkuil
2008-12-16 17:38   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081212102529.77b4e105@gmail.com \
    --to=dougsland@gmail.com \
    --cc=hydrologiccycle@gmail.com \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.