* [JGIT PATCH] Fix typos in comments / testcase output
@ 2008-12-12 10:55 Mike Ralphson
2008-12-12 15:30 ` Shawn O. Pearce
0 siblings, 1 reply; 2+ messages in thread
From: Mike Ralphson @ 2008-12-12 10:55 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: git, Mike Ralphson, Robin Rosenberg
Signed-off-by: Mike Ralphson <mike@abacus.co.uk>
---
Is it me, or is the actual maintainer of JGIT/EGIT not actually
mentioned anywhere? Apologies if I've got the to and cc round
the wrong way 8-)
This patch is the product of
find . -name "*.java" -type f -exec aspell --mode=ccpp -c {} \;
I would post my aspell wordlists but they're polluted by other
projects...
Possibly also s/packes to/packs so/ in README?
.../org/spearce/egit/core/GitMoveDeleteHook.java | 2 +-
.../org/spearce/jgit/lib/RepositoryTestCase.java | 2 +-
.../spearce/jgit/revwalk/RevCommitParseTest.java | 2 +-
.../spearce/jgit/transport/BundleWriterTest.java | 2 +-
.../spearce/jgit/transport/FetchConnection.java | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/GitMoveDeleteHook.java b/org.spearce.egit.core/src/org/spearce/egit/core/GitMoveDeleteHook.java
index cc4059c..7faa65a 100644
--- a/org.spearce.egit.core/src/org/spearce/egit/core/GitMoveDeleteHook.java
+++ b/org.spearce.egit.core/src/org/spearce/egit/core/GitMoveDeleteHook.java
@@ -122,7 +122,7 @@ public boolean moveFolder(final IResourceTree tree, final IFolder source,
final IFolder destination, final int updateFlags,
final IProgressMonitor monitor) {
// TODO: Implement this. Should be relatively easy, but consider that
- // Eclipse thinks folders are real thinsgs, while Git does not care.
+ // Eclipse thinks folders are real things, while Git does not care.
return FINISH_FOR_ME;
}
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
index 8937145..9e48fde 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/lib/RepositoryTestCase.java
@@ -94,7 +94,7 @@ protected void configure() {
/**
* Utility method to delete a directory recursively. It is
- * also used internally. If a file or directory cannote be removed
+ * also used internally. If a file or directory cannot be removed
* it throws an AssertionFailure.
*
* @param dir
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevCommitParseTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevCommitParseTest.java
index 805e29e..9b95924 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevCommitParseTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevCommitParseTest.java
@@ -226,7 +226,7 @@ public void testParse_explicit_bad_encoded() throws Exception {
*
* What happens here is that an encoding us given, but data is not encoded
* that way (and we can detect it), so we try other encodings. Here data could
- * actually be decoded in the stated encoding, but we overide using UTF-8.
+ * actually be decoded in the stated encoding, but we override using UTF-8.
*
* @throws Exception
*/
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/transport/BundleWriterTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/transport/BundleWriterTest.java
index 3cfb8b1..f13d25c 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/transport/BundleWriterTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/transport/BundleWriterTest.java
@@ -117,7 +117,7 @@ assertEquals(db.resolve("c").name(), newRepo.resolve("refs/heads/cc")
// Check that we actually needed the first bundle
Repository newRepo2 = createNewEmptyRepo();
fetchResult = fetchFromBundle(newRepo2, bundle);
- fail("We should not be able to fetch from bundle with prerequisistes that are not fulfilled");
+ fail("We should not be able to fetch from bundle with prerequisites that are not fulfilled");
} catch (MissingBundlePrerequisiteException e) {
assertTrue(e.getMessage()
.indexOf(db.resolve("refs/heads/a").name()) >= 0);
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/FetchConnection.java b/org.spearce.jgit/src/org/spearce/jgit/transport/FetchConnection.java
index 461ad71..a56ca6c 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/FetchConnection.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/FetchConnection.java
@@ -126,7 +126,7 @@ public void fetch(final ProgressMonitor monitor, final Collection<Ref> want)
* able to supply a fully connected graph to the client (although it may
* only be transferring the parts the client does not yet have). Its faster
* to assume such remote peers are well behaved and send the correct
- * response to the client. In such tranports this method returns false.
+ * response to the client. In such transports this method returns false.
*
* @return true if the last fetch had to perform a connectivity check on the
* client side in order to succeed; false if the last fetch assumed
--
1.6.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [JGIT PATCH] Fix typos in comments / testcase output
2008-12-12 10:55 [JGIT PATCH] Fix typos in comments / testcase output Mike Ralphson
@ 2008-12-12 15:30 ` Shawn O. Pearce
0 siblings, 0 replies; 2+ messages in thread
From: Shawn O. Pearce @ 2008-12-12 15:30 UTC (permalink / raw)
To: Mike Ralphson; +Cc: git, Mike Ralphson, Robin Rosenberg
Mike Ralphson <mike@abacus.co.uk> wrote:
> Signed-off-by: Mike Ralphson <mike@abacus.co.uk>
Thanks, I've applied this change, and the README correction you
noted but didn't send a patch for. :-)
> Is it me, or is the actual maintainer of JGIT/EGIT not actually
> mentioned anywhere? Apologies if I've got the to and cc round
> the wrong way 8-)
Robin and I run JGit and EGit as a dual-maintainer approach.
We both have write access to the master repository and we apply
each other's patches rather than push directly ourselves. It
helps keep us from cutting corners.
Although I just broke that rule by pushing my own patch to README
and my own patch to SUBMITTING_PATCHES to address the other points
you raised, but these are two auxiliary documents that we don't
pay much attention to, hence they have fallen into disarray... :-\
--
Shawn.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-12 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-12 10:55 [JGIT PATCH] Fix typos in comments / testcase output Mike Ralphson
2008-12-12 15:30 ` Shawn O. Pearce
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.