All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
	netdev <netdev@vger.kernel.org>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] virtio_net: add link status handling
Date: Fri, 12 Dec 2008 18:34:48 +1030	[thread overview]
Message-ID: <200812121834.49464.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1228934084.5384.66.camel@blaa>

On Thursday 11 December 2008 05:04:44 Mark McLoughlin wrote:
> On Tue, 2008-12-09 at 21:11 -0600, Anthony Liguori wrote:
> > Rusty Russell wrote:
> > > On Wednesday 10 December 2008 08:02:14 Anthony Liguori wrote:    
> > >> It would be nice if the virtio-net card wrote some acknowledgement that 
> > >> it has received the link status down/up events.
> > >
> > > How about of every status change event? ie. a generic virtio_pci solution?
> > 
> > A really simple way to do it would just be to have another status field 
> > that was the guest's status (verses the host requested status which the 
> > current field is).  All config reads/writes result in exits so it's easy 
> > to track.
> > 
> > Adding YA virtio event may be a little overkill.
> 
> Sounds very reasonable; that and Rusty's "mask out unknown bits"
> suggestion in the version below.

Not quite what I was after.  I've taken the original patch, added the
masking change.  I'll test here and feed to DaveM.

As far as Anthony's live migrate race, I've decided to declare with
Canutian arrogance that it Will Never Happen.

Cheers,
Rusty.

  reply	other threads:[~2008-12-12  8:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09 10:19 [PATCH] virtio_net: add link status handling Mark McLoughlin
2008-12-09 21:32 ` Anthony Liguori
2008-12-09 23:53   ` Rusty Russell
2008-12-10  3:11     ` Anthony Liguori
2008-12-10 18:34       ` Mark McLoughlin
2008-12-12  8:04         ` Rusty Russell [this message]
2009-01-07 18:18           ` Mark McLoughlin
2009-01-09 11:51             ` Mark McLoughlin
2008-12-09 23:56 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812121834.49464.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.