From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Arcangeli Subject: Re: [PATCH 2 of 5] add can_dma/post_dma for direct IO Date: Sat, 13 Dec 2008 15:39:44 +0100 Message-ID: <20081213143944.GD30537@random.random> References: <4942B841.6010900@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gerd Hoffmann , qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com, chrisw@redhat.com To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56154 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbYLMOjv (ORCPT ); Sat, 13 Dec 2008 09:39:51 -0500 Content-Disposition: inline In-Reply-To: <4942B841.6010900@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Dec 12, 2008 at 01:15:13PM -0600, Anthony Liguori wrote: > void *cpu_physical_memory_map(target_phys_addr_t addr, ram_addr_t size, int > is_write); Just a side note (doesn't mean I agree with the above), it doesn't make sense to use an ram_addr_t size when you return a 32bit address on 32bit qemu build. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBVer-00035s-9z for qemu-devel@nongnu.org; Sat, 13 Dec 2008 09:39:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBVep-00033g-IR for qemu-devel@nongnu.org; Sat, 13 Dec 2008 09:39:53 -0500 Received: from [199.232.76.173] (port=57613 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBVep-00033b-Ft for qemu-devel@nongnu.org; Sat, 13 Dec 2008 09:39:51 -0500 Received: from mx2.redhat.com ([66.187.237.31]:53607) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBVep-0006YX-An for qemu-devel@nongnu.org; Sat, 13 Dec 2008 09:39:51 -0500 Date: Sat, 13 Dec 2008 15:39:44 +0100 From: Andrea Arcangeli Message-ID: <20081213143944.GD30537@random.random> References: <4942B841.6010900@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4942B841.6010900@codemonkey.ws> Subject: [Qemu-devel] Re: [PATCH 2 of 5] add can_dma/post_dma for direct IO Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: chrisw@redhat.com, avi@redhat.com, Gerd Hoffmann , kvm@vger.kernel.org, qemu-devel@nongnu.org On Fri, Dec 12, 2008 at 01:15:13PM -0600, Anthony Liguori wrote: > void *cpu_physical_memory_map(target_phys_addr_t addr, ram_addr_t size, int > is_write); Just a side note (doesn't mean I agree with the above), it doesn't make sense to use an ram_addr_t size when you return a 32bit address on 32bit qemu build.