From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: kernel panics with net_rx_action on kernels >2.6.26 Date: Mon, 15 Dec 2008 13:35:21 +0000 Message-ID: <20081215133521.GA6697@ff.dom.local> References: <20081214.224800.125614949.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: alexander.huemer@sbg.ac.at, linux-net@vger.kernel.org, netdev@vger.kernel.org To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20081214.224800.125614949.davem@davemloft.net> Sender: linux-net-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 15-12-2008 07:48, David Miller wrote: > From: Alexander Huemer > Date: Sun, 14 Dec 2008 15:17:32 +0100 > > Networking developers generally don't read the linux-net list, it is > for user configuration and basic questions only, not bug reports or > technical discussions. > > netdev is the place to report such things, and I've added that to the > CC: > >> one of my machines (x86) crashes under heavy network load with kernels >>> 2.6.26, i tried quite everything possible between 2.6.27 and 2.6.28-rc8. >> lspci -vv: http://xx.vu/~ahuemer/lspci_vv.txt >> of the quad nic 2 ports are used, the machine is acting as a iptables >> firewall/router. >> >> kernel config (2.6.26) http://xx.vu/~ahuemer/config >> screenshot of the panic: >> http://xx.vu/~ahuemer/kernel_panic_net_rx_action.jpg >> >> as i do not have any problems with kernels <=2.6.26, i doubt that this >> is a hardware problem. >> in case of the panic, nothing is written to the system log. >> >> any hints welcome. >> please CC me on replies, i am not subscribed to the mailing list. Could you try this patch, please? Jarek P. --- drivers/net/starfire.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c index 0358809..f86d6bb 100644 --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@ -1503,6 +1503,11 @@ static int __netdev_rx(struct net_device *dev, int *quota) desc->status = 0; np->rx_done = (np->rx_done + 1) % DONE_Q_SIZE; } + + if (*quota == 0) { /* out of rx quota */ + retcode = 1; + goto out; + } writew(np->rx_done, np->base + CompletionQConsumerIdx); out: