From: David Brownell <david-b@pacbell.net>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
gregkh@suse.de, felipe.balbi@nokia.com
Cc: linux-usb@vger.kernel.org, khilman@deeprootsystems.com,
davinci-linux-open-source@linux.davincidsp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] musb: fix DaVinci build again
Date: Tue, 23 Dec 2008 17:07:47 -0800 [thread overview]
Message-ID: <200812231707.48195.david-b@pacbell.net> (raw)
In-Reply-To: <49517305.4000100@ru.mvista.com>
On Tuesday 23 December 2008, Sergei Shtylyov wrote:
> > Yeah, I sent a DaVinci build fix patch in plenty of time to
> > be merged for *2.6.27* (!!!!) but still the key parts are
> > missing, and have not managed to make it into mainline.
>
> Try breakinjg the patches into smaller pieces next time, so they may
> get thru the maintainer's sieve more easily. :-)
That wasn't the issue back then. If you look at
c767c1c6f1febbd1351cc152bba6e37889322d17
which got merged after 2.6.27 shipped, you'll notice that
someone stripped out the following parts from the original
patch, which were even referenced in the patch comment.
This worked as submitted, but then got broken during merge;
and fixes have been re-sent several times already.
Plus, some other stuff has merged which prevents linking.
Fixes for those parts have been re-sent several times too.
- Dave
============= CUT HERE
From: David Brownell <dbrownell@users.sourceforge.net>
Build fixes that somehow got stripped out of the earlier build
fix patch ...
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
drivers/usb/musb/davinci.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/usb/musb/davinci.c
+++ b/drivers/usb/musb/davinci.c
@@ -31,10 +31,11 @@
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/gpio.h>
+#include <linux/gpio.h>
+
+#include <mach/hardware.h>
+#include <mach/memory.h>
-#include <asm/arch/hardware.h>
-#include <asm/arch/memory.h>
-#include <asm/arch/gpio.h>
#include <asm/mach-types.h>
#include "musb_core.h"
next prev parent reply other threads:[~2008-12-24 1:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812072341.50012.sshtylyov@ru.mvista.com>
[not found] ` <494A7729.6090102@ru.mvista.com>
[not found] ` <494A7809.1040504@ru.mvista.com>
[not found] ` <494E2450.9080601@ru.mvista.com>
2008-12-23 11:46 ` [PATCH] musb: fix DaVinci build again Sergei Shtylyov
2008-12-23 17:38 ` David Brownell
2008-12-23 23:23 ` Sergei Shtylyov
2008-12-24 1:07 ` David Brownell [this message]
2008-12-24 2:27 ` Felipe Balbi
2008-12-24 3:52 ` David Brownell
2008-12-25 20:37 ` David Brownell
2008-12-24 15:04 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812231707.48195.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=felipe.balbi@nokia.com \
--cc=gregkh@suse.de \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.