From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LFINK-0007fd-9N for mharc-grub-devel@gnu.org; Tue, 23 Dec 2008 20:17:26 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LFINI-0007fD-Nt for grub-devel@gnu.org; Tue, 23 Dec 2008 20:17:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LFING-0007ed-T1 for grub-devel@gnu.org; Tue, 23 Dec 2008 20:17:23 -0500 Received: from [199.232.76.173] (port=44973 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LFING-0007ea-ML for grub-devel@gnu.org; Tue, 23 Dec 2008 20:17:22 -0500 Received: from gateway08.websitewelcome.com ([69.56.142.29]:53360) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LFING-00071u-AC for grub-devel@gnu.org; Tue, 23 Dec 2008 20:17:22 -0500 Received: (qmail 7470 invoked from network); 24 Dec 2008 01:36:52 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway08.websitewelcome.com with SMTP; 24 Dec 2008 01:36:52 -0000 Received: from c-67-185-177-95.hsd1.wa.comcast.net ([67.185.177.95]:48130 helo=localhost) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1LFINB-00078W-2Y; Tue, 23 Dec 2008 19:17:17 -0600 Date: Tue, 23 Dec 2008 17:17:11 -0800 From: Colin D Bennett To: The development of GRUB 2 Message-ID: <20081223171711.15128818@gibibit.com> In-Reply-To: <49513053.20207@nic.fi> References: <20080901092753.3918cf73@gamma.lan> <20081004214640.5ab21f53@gibibit.com> <48E87FB9.8070603@nic.fi> <20081030121106.4efffecc@gibibit.com> <20081030205736.7e080a5e@gibibit.com> <493ADE06.7080001@nic.fi> <20081222091443.7280e623@gibibit.com> <49513053.20207@nic.fi> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.14.5; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/nVK89GzJh/x1xekD7oHQQrt"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Subject: Re: [PATCH] GSoC #10 new font engine (UTF-8 support+bugfix) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Dec 2008 01:17:25 -0000 --Sig_/nVK89GzJh/x1xekD7oHQQrt Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 23 Dec 2008 20:39:15 +0200 Vesa J=C3=A4=C3=A4skel=C3=A4inen wrote: > Colin D Bennett wrote: > > On Sat, 06 Dec 2008 22:18:14 +0200 > > Vesa J=C3=A4=C3=A4skel=C3=A4inen wrote: > >=20 > >> Colin D Bennett wrote: > >>> Update:=20 > >>> > >>> I fixed an error pointed out to me by Y.Volta:=20 > >>> In grub_font_get(), if no fonts are loaded, a null pointer is > >>> dereferenced. This is fixed in the attached patch. > >>> > >>> The grub_font_get() function now returns a dummy font object (a > >>> statically allocated font object with no characters) so that > >>> callers of grub_font_get() can be assured that the return value > >>> will never be NULL. If no fonts are loaded, then the "unknown > >>> glyph" will be used for all characters, but it will be safe. > >> Hi Colin, > >> > >> I applied this patch against SVN today and tried it out. And > >> noticed that gfxterm gets a bit "broken" after this. Was this the > >> thing that I promised to look at :) ? Or was my merge just > >> incomplete? > >=20 > > There are two problems with gfxterm now: > >=20 > > 1. unifont has problems rendering glyphs: they seem to be rendered > > too wide (maybe), and the cursor ends up being drawn after each > > character resulting in t_e_x_t_ _t_h_a_t_ _l_o_o_k_s like this. > >=20 > > 2. With fonts that otherwise work (i.e. "Fixed 10" for me), > > sometimes a few random junk characters with weird > > background/foreground colors show up in gfxterm -- mainly when it > > is first set as the terminal, leading me to think that there is > > some uninitialized memory. >=20 > I think I have workable solution for these now in my local copy. Great. > >> Videotest was fine however. (or how fine it can be with just > >> unifont.bdf) > >=20 > > I should look closely at unifont.bdf and the .pf2 conversion and see > > why GRUB is rendering it weirdly in gfxterm. >=20 > Actually what we want is to have improved conversion tool. >=20 > If I make full conversion it generates ~1.7 MiB font file which does > not fit to floppy. Now if we could specify unicode ranges what to put > there it would make them smaller. Also, I'd like to add LZMA compression as previously discussed, which I think would give a huge improvement. > This would be similar to how you specify ranges to old pff converter. > I was planning to make such modification to handle near term goal. >=20 > Actually it would be nice if converter tool would be in C. Then it > could be compiled and executed easily during normal compilation > process. Viewer application is not so important and it can be > external to project . Same time with C implementation it would be > easy to add compression there too. It certainly could be rewritten in C, but it would take some time. > >> After: > >> loadfont /boot/grub/unifont.pf2 > >> > >> lsfonts gives: > >> Loaded fonts: > >> Unknown -1 > >> > >> Is this expected? > >=20 > > Yes, since there is no 'POINT_SIZE' or 'FAMILY_NAME' attribute in > > the unifont.bdf file. I added these manually, and it then showed up > > properly in the lsfonts listing (and can then be specified using the > > name/size in GRUB). >=20 > Perhaps this addition should be moved to GNU Unifont's upstream? Perhaps. > > Sorry for the delay getting back to you; now that the font patches > > are going in, I will be ready to continue work on submitting the > > graphical menu system patches. I've received e-mails from a number > > of people who have found my project web site and want to try out > > the graphical menu, and are asking when it will be merged into GRUB. >=20 > I'll try to get them in. But I have to make it in way to normal grub > operation do not break at same time. Temporary this means probably > that toolchain is there in Java form unless you can make quickly the > new converter. It can start without compression. What we want is to > match functionality of old font converter. Eg. specify ranges and then > generate file based on that one. Well, I don't have time right now to rewrite the converter; not for a couple of weeks, at least. I'm certainly willing to do it, so I'll get to it when I can, and then we can replace the Java converter. Regards, Colin --Sig_/nVK89GzJh/x1xekD7oHQQrt Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAklRjZwACgkQokx8fzcGbYf9swCghUclci7DciugfNdL6SpKDKZg cHUAnjZHOr9TrlM1Q6gK4jIgkmSSPiz+ =00pX -----END PGP SIGNATURE----- --Sig_/nVK89GzJh/x1xekD7oHQQrt--