From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 1/8] KVM: Add MSI_ACTION flag for assigned irq Date: Tue, 23 Dec 2008 15:32:24 -0200 Message-ID: <20081223173224.GA5449@amt.cnet> References: <1230019231-16543-1-git-send-email-sheng@linux.intel.com> <1230019231-16543-2-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42563 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbYLWRcd (ORCPT ); Tue, 23 Dec 2008 12:32:33 -0500 Content-Disposition: inline In-Reply-To: <1230019231-16543-2-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Dec 23, 2008 at 04:00:24PM +0800, Sheng Yang wrote: > For MSI disable feature later. > > Notice I changed ABI here, but due to no userspace patch, I think it's OK. > > Signed-off-by: Sheng Yang > --- > include/linux/kvm.h | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > index ef7f98e..5b965f6 100644 > --- a/include/linux/kvm.h > +++ b/include/linux/kvm.h > @@ -544,6 +544,7 @@ struct kvm_assigned_irq { > > #define KVM_DEV_ASSIGN_ENABLE_IOMMU (1 << 0) > > -#define KVM_DEV_IRQ_ASSIGN_ENABLE_MSI (1 << 0) > +#define KVM_DEV_IRQ_ASSIGN_MSI_ACTION (1 << 0) > +#define KVM_DEV_IRQ_ASSIGN_ENABLE_MSI (1 << 1) This is a little confusing. KVM_DEV_IRQ_ASSIGN_MSI_ACTION is assigned from userspace, and in the patchset used in conjunction with msi2intx which is a module parameter. Is there anything that blocks control of msi2intx translate behaviour from userspace? Perhaps add a KVM_DEV_IRQ_UNASSIGN ioctl, and pass the desired guest/host irq types on the IRQ_ASSIGN ioctl, thus removing some of the kernel complexity.