From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 8/8] KVM: Merge MSI handling to kvm_set_irq
Date: Tue, 23 Dec 2008 16:10:20 -0200
Message-ID: <20081223181020.GD5449@amt.cnet>
References: <1230019231-16543-1-git-send-email-sheng@linux.intel.com> <1230019231-16543-9-git-send-email-sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:48722 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751022AbYLWSK3 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 23 Dec 2008 13:10:29 -0500
Content-Disposition: inline
In-Reply-To: <1230019231-16543-9-git-send-email-sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Dec 23, 2008 at 04:00:31PM +0800, Sheng Yang wrote:
> Using kvm_set_irq to handle all interrupt injection.
> 
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  include/linux/kvm_host.h |    2 +-
>  virt/kvm/irq_comm.c      |   96 ++++++++++++++++++++++++++++++++++++++-------
>  virt/kvm/kvm_main.c      |   75 +++---------------------------------
>  3 files changed, 88 insertions(+), 85 deletions(-)
> 
> --- a/virt/kvm/irq_comm.c
> +++ b/virt/kvm/irq_comm.c
> @@ -20,28 +20,94 @@
>   */
>  

>  #ifdef CONFIG_X86
> -	kvm_pic_set_irq(pic_irqchip(kvm), irq, !!(*irq_state));
> +	gsi_msg = kvm_find_gsi_msg(kvm, gsi);

It was nicer isolated in assigned_device_msi_dispatch.

> -#ifdef CONFIG_X86
> -#include <asm/msidef.h>
> -#endif

And there's quite some x86 specific code sneaking into virt/kvm. Ideally
platform specific parts should be hidden behind interfaces.