From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [patch 2.6.28-rc9] spi: spi_write_then_read() regression fix Date: Wed, 24 Dec 2008 10:58:57 +0200 Message-ID: <20081224085844.GA11197@diamond.tkos.co.il> References: <200812202332.36281.david-b@pacbell.net> <200812231953.26407.david-b@pacbell.net> <200812240039.32008.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Vernon Sauder , Linus Torvalds , Andrew Morton To: David Brownell Return-path: Content-Disposition: inline In-Reply-To: <200812240039.32008.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Hi David, On Wed, Dec 24, 2008 at 12:39:31AM -0800, David Brownell wrote: > I've certainly seen a couple drivers that handled the > full duplex behavior incorrectly, until they fixed that > bug. As in, they wrote the tx_buf *then* read rx_buf > (a half-duplex model) instead of doing them concurrently > (the full-duplex model a spi_master must implement). May you name those drivers and the commits with the bug fixes? I couldn't find them in Linus' tree. I'm working on an SPI master (DesignWare) driver and I want to make sure that I'm implementing the API correctly. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il - ------------------------------------------------------------------------------