From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbYLZH6w (ORCPT ); Fri, 26 Dec 2008 02:58:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753003AbYLZH6j (ORCPT ); Fri, 26 Dec 2008 02:58:39 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37912 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752802AbYLZH6i (ORCPT ); Fri, 26 Dec 2008 02:58:38 -0500 Date: Thu, 25 Dec 2008 23:58:41 -0800 (PST) Message-Id: <20081225.235841.230537795.davem@davemloft.net> To: hannes@hanneseder.net Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/27] drivers/net/atlx: fix sparse warnings: make symbols static From: David Miller In-Reply-To: <20081222191544.11807.31114.stgit@vmbox.hanneseder.net> References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> <20081222191544.11807.31114.stgit@vmbox.hanneseder.net> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hannes Eder Date: Mon, 22 Dec 2008 20:15:45 +0100 > Fix this sparse warnings: > > drivers/net/atlx/atl1.c:198:16: warning: symbol 'atl1_check_options' was not declared. Should it be static? > drivers/net/atlx/atl1.c:526:5: warning: symbol 'atl1_read_mac_addr' was not declared. Should it be static? > > Signed-off-by: Hannes Eder Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Fri, 26 Dec 2008 07:58:41 +0000 Subject: Re: [PATCH 06/27] drivers/net/atlx: fix sparse warnings: make Message-Id: <20081225.235841.230537795.davem@davemloft.net> List-Id: References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> <20081222191544.11807.31114.stgit@vmbox.hanneseder.net> In-Reply-To: <20081222191544.11807.31114.stgit@vmbox.hanneseder.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: hannes@hanneseder.net Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Hannes Eder Date: Mon, 22 Dec 2008 20:15:45 +0100 > Fix this sparse warnings: > > drivers/net/atlx/atl1.c:198:16: warning: symbol 'atl1_check_options' was not declared. Should it be static? > drivers/net/atlx/atl1.c:526:5: warning: symbol 'atl1_read_mac_addr' was not declared. Should it be static? > > Signed-off-by: Hannes Eder Applied.