From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mBVAD7cM020282 for ; Wed, 31 Dec 2008 05:13:07 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id mBVACpLF021276 for ; Wed, 31 Dec 2008 05:12:51 -0500 Date: Wed, 31 Dec 2008 08:12:43 -0200 From: Mauro Carvalho Chehab To: Hans Verkuil Message-ID: <20081231081243.0cecad1d@pedra.chehab.org> In-Reply-To: <200812311052.40693.hverkuil@xs4all.nl> References: <8ef00f5a0812171449o19fe5656wec05889b738e7aed@mail.gmail.com> <20081230203235.1b7eecf3@pedra.chehab.org> <200812311052.40693.hverkuil@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: video4linux-list@redhat.com, Fabio Belavenuto Subject: Re: [PATCH] Add TEA5764 radio driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: On Wed, 31 Dec 2008 10:52:40 +0100 Hans Verkuil wrote: > Hi Mauro, > > Did you see my review of this driver? > > (http://lists-archives.org/video4linux/26062-add-tea5764-radio-driver.html) > > IMHO this driver shouldn't be added in this form. It's up to you of course > to decide this, but I just want to make sure you read my posting. No, I haven't seen. I'm not sure why, but patchwork didn't show me your review. My comments about the points you raised: a) Yes, the proper approach is to split it into 2 separate drivers: 1) a Motorola i2c bridge driver; 2) a generic tea5764 driver; I would very much appreciate if Fabio can do this work, allowing others to use tea5764 driver; b) AFAIK, tea5764 is not so close to tea5767, so probably the right decision is to have it as a separate driver; c) The same design trouble on radio-tea5764 is also present on other radio-* drivers; d) While this design doesn't allow sharing tea5764 driver, for now, we have at least something. A future patch may split it into two drivers. That's why I decided to apply it. Fábio, Could you please work on split it into two drivers? You can use cx88 or saa7134 as examples. On those drivers, the i2c stuff is at *-i2c.c, and the radio interface are at *-video.c. Cheers, Mauro -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list