From: Hans Verkuil <hverkuil@xs4all.nl>
To: video4linux-list@redhat.com
Cc: Fabio Belavenuto <belavenuto@gmail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] Add TEA5764 radio driver
Date: Wed, 31 Dec 2008 10:52:40 +0100 [thread overview]
Message-ID: <200812311052.40693.hverkuil@xs4all.nl> (raw)
In-Reply-To: <20081230203235.1b7eecf3@pedra.chehab.org>
On Tuesday 30 December 2008 23:32:35 Mauro Carvalho Chehab wrote:
> On Wed, 17 Dec 2008 20:49:33 -0200
>
> "Fabio Belavenuto" <belavenuto@gmail.com> wrote:
> > Add support for radio driver TEA5764 from NXP.
> > This chip is connected in pxa I2C bus in EZX phones
> > from Motorola, the chip is used in phone model A1200.
> > This driver is for OpenEZX project (www.openezx.org)
> > Tested with A1200 phone, openezx kernel and fm-tools
>
> Hi Fabio,
>
> I've committed the patch. Thanks!
>
> I had to do a few changes, since V4L now have their own fops definition,
> due to a patch that I've just merged.
>
> Could you please test and confirm if the changes I made didn't affect the
> driver?
>
> Ah, I also fixed 3 small codingsyle violations.
Hi Mauro,
Did you see my review of this driver?
(http://lists-archives.org/video4linux/26062-add-tea5764-radio-driver.html)
IMHO this driver shouldn't be added in this form. It's up to you of course
to decide this, but I just want to make sure you read my posting.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-12-31 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 22:49 [PATCH] Add TEA5764 radio driver Fabio Belavenuto
2008-12-18 1:57 ` Alexey Klimov
2008-12-18 21:12 ` Fábio Belavenuto
2008-12-18 11:52 ` Hans Verkuil
2008-12-18 21:13 ` Fábio Belavenuto
2008-12-30 22:32 ` Mauro Carvalho Chehab
2008-12-31 9:52 ` Hans Verkuil [this message]
2008-12-31 10:12 ` Mauro Carvalho Chehab
2009-01-02 2:22 ` Fábio Belavenuto
2009-02-11 7:10 ` Hans Verkuil
2009-02-17 16:38 ` Fabio Belavenuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812311052.40693.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=belavenuto@gmail.com \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.