All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kbuild@vger.kernel.org, sam@ravnborg.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/3] KBUILD: Add script to manipulate .config files on the command line
Date: Sat, 3 Jan 2009 18:12:55 +0100	[thread overview]
Message-ID: <20090103171255.GO496@one.firstfloor.org> (raw)
In-Reply-To: <200901031154.44868.arnd@arndb.de>

On Sat, Jan 03, 2009 at 11:54:44AM +0100, Arnd Bergmann wrote:
> > I extracted most of the CONFIG manipulation code from one of my
> > build scripts into a new shell script scripts/config
> 
> This looks very useful, thanks for sharing.
> 
> > The script is not integrated with the normal Kconfig machinery
> > and doesn't do any checking against Kconfig files, but just manipulates
> > that text format. This is always done at make time anyways.
> 
> Why? I would imagine it to be useful to get immediate feedback
> whether changing the option was successful. It should be easy to
> run scripts/kconfig/conf -o on the config file afterwards.

Mostly so that the script doesn't need to know about the source
directory. That would be another argument, making it harder to use. 
At least my build scripts often run in a different environment. And
make always checks it anyways.

Also I wasn't sure how to change the filename of the config file
without using Kconfig internals.  That would be less of a concern
now if it was merged, but it was one out of tree.

> 
> My normal workflow when changing single options is to remove the
> line from .config and call make oldconfig again. What I would
> like to see most here is something like
> 
> ./scripts/config --reconfigure smp
> Remove SMP from .config, and do oldconfig to ask again.

You don't need the make oldconfig, make always does that automatically.

BTW there's an undocumented option to do this, but I intentionally
didn't document it because it doesn't work with --file due to the
reasons stated above.

-Andi

-- 
ak@linux.intel.com

  reply	other threads:[~2009-01-03 16:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-03  2:21 [PATCH] [1/3] KBUILD: Add script to manipulate .config files on the command line Andi Kleen
2009-01-03  2:21 ` [PATCH] [2/3] KBUILD: Add a symlink to the source for separate objdirs Andi Kleen
2009-01-07 20:29   ` Sam Ravnborg
2009-01-03  2:21 ` [PATCH] [3/3] KBUILD: Add a "bin" symlink for the scripts directory too Andi Kleen
2009-01-07 20:27   ` Sam Ravnborg
2009-01-07 21:30     ` Andi Kleen
2009-01-07 21:36       ` Sam Ravnborg
2009-01-03 10:54 ` [PATCH] [1/3] KBUILD: Add script to manipulate .config files on the command line Arnd Bergmann
2009-01-03 17:12   ` Andi Kleen [this message]
2009-01-07 20:18 ` Sam Ravnborg
2009-01-07 21:33   ` Andi Kleen
2009-01-07 22:07     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090103171255.GO496@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=arnd@arndb.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.