All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hans Werner" <HWerner4@gmx.de>
To: linux-dvb@linuxtv.org
Subject: [linux-dvb] [PATCH] stb6100: stb6100_init fix
Date: Mon, 05 Jan 2009 16:10:50 +0100	[thread overview]
Message-ID: <20090105151050.293110@gmx.net> (raw)
In-Reply-To: <c74595dc0901042308j24fcbdebq3d6c51d2c68c8a73@mail.gmail.com>

Two issues in stb6100_init : the call to stb6100_set_bandwidth needs an argument in Hz
not kHz, and a comment incorrectly says MHz instead of Hz.  I don't know if this caused
real problems anywhere.

This patch is for v4l-dvb, but it is also needs to be fixed in s2-liplianin.

diff -r b7e7abe3e3aa linux/drivers/media/dvb/frontends/stb6100.c
--- a/linux/drivers/media/dvb/frontends/stb6100.c
+++ b/linux/drivers/media/dvb/frontends/stb6100.c
@@ -434,11 +434,11 @@ static int stb6100_init(struct dvb_front
        status->refclock        = 27000000;     /* Hz   */
        status->iqsense         = 1;
        status->bandwidth       = 36000;        /* kHz  */
-       state->bandwidth        = status->bandwidth * 1000;     /* MHz  */
+       state->bandwidth        = status->bandwidth * 1000;     /* Hz   */
        state->reference        = status->refclock / 1000;      /* kHz  */

        /* Set default bandwidth.       */
-       return stb6100_set_bandwidth(fe, status->bandwidth);
+       return stb6100_set_bandwidth(fe, state->bandwidth);
 }

 static int stb6100_get_state(struct dvb_frontend *fe,
-- 
Release early, release often.

Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

  parent reply	other threads:[~2009-01-05 15:11 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 22:37 [linux-dvb] Technisat HD2 cannot szap/scan Pavel Hofman
2008-12-02  6:13 ` Michel Verbraak
2008-12-02 22:31   ` Pavel Hofman
     [not found]     ` <c74595dc0812022332s2ef51d1cn907cbe5e4486f496@mail.gmail.com>
     [not found]       ` <c74595dc0812022347j37e83279mad4f00354ae0e611@mail.gmail.com>
2008-12-03 23:24         ` Pavel Hofman
2008-12-05  6:22           ` [linux-dvb] Technisat HD2 cannot szap/scan (possible diseqc problem) Michel Verbraak
2008-12-05  9:00             ` Alex Betis
2008-12-06 17:07               ` Hans Werner
2008-12-06 17:28                 ` Alex Betis
2008-12-06 17:37                   ` Hans Werner
2008-12-09 15:34                 ` [linux-dvb] [PATCH] Technisat HD2 cannot szap/scan Hans Werner
2008-12-15 14:30                   ` [linux-dvb] Mantis Bug (was Technisat HD2 cannot szap/scan) Hans Werner
2009-01-04 19:24                     ` [linux-dvb] [PATCH] " Hans Werner
     [not found]                       ` <c74595dc0901042308j24fcbdebq3d6c51d2c68c8a73@mail.gmail.com>
2009-01-05 15:10                         ` Hans Werner [this message]
     [not found]                           ` <b8a3b1ca0901051233u635b6d14u33d9d3b2f3d1ef61@mail.gmail.com>
2009-01-05 20:37                             ` [linux-dvb] Fwd: [PATCH] stb6100: stb6100_init fix Tomáš Skočdopole
2009-01-06 17:21                               ` [linux-dvb] " Newsy Paper
2009-01-05 16:45                       ` [linux-dvb] [PATCH] Mantis Bug (was Technisat HD2 cannot szap/scan) gimli
2009-01-05 17:36                         ` Hans Werner
2009-01-05 18:04                           ` gimli
2009-01-05 18:09                           ` gimli
2009-02-05 12:34                             ` Hans Werner
2009-02-06  7:14                               ` Alexey Klimov
2009-02-06 11:47                                 ` Hans Werner
2008-12-07 15:06           ` [linux-dvb] Technisat HD2 cannot szap/scan Pavel Hofman
2008-12-07 18:08             ` BOUWSMA Barry
2008-12-08 18:43               ` Pavel Hofman
2008-12-09  6:38                 ` BOUWSMA Barry
2008-12-08  6:52             ` Michel Verbraak
2008-12-08 18:54               ` Pavel Hofman
     [not found]             ` <c74595dc0812070822p73746bdel9894de34c87a733f@mail.gmail.com>
2008-12-08 18:39               ` Pavel Hofman
2008-12-08 19:53                 ` Alex Betis
2008-12-08 20:10                 ` BOUWSMA Barry
2008-12-08 22:19                   ` Pavel Hofman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090105151050.293110@gmx.net \
    --to=hwerner4@gmx.de \
    --cc=linux-dvb@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.